netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: netdev@vger.kernel.org
Cc: Frank Wunderlich <frank-w@public-files.de>,
	Daniel Golle <daniel@makrotopia.org>
Subject: [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links
Date: Fri, 24 Mar 2023 15:04:04 +0100	[thread overview]
Message-ID: <20230324140404.95745-1-nbd@nbd.name> (raw)

Using the QDMA tx scheduler to throttle tx to line speed works fine for
switch ports, but apparently caused a regression on non-switch ports.

Based on a number of tests, it seems that this throttling can be safely
dropped without re-introducing the issues on switch ports that the
tx scheduling changes resolved.

Link: https://lore.kernel.org/netdev/trinity-92c3826f-c2c8-40af-8339-bc6d0d3ffea4-1678213958520@3c-app-gmx-bs16/
Fixes: f63959c7eec3 ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Reported-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index a94aa08515af..282f9435d5ff 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -763,8 +763,6 @@ static void mtk_mac_link_up(struct phylink_config *config,
 		break;
 	}
 
-	mtk_set_queue_speed(mac->hw, mac->id, speed);
-
 	/* Configure duplex */
 	if (duplex == DUPLEX_FULL)
 		mcr |= MAC_MCR_FORCE_DPX;
-- 
2.39.0


             reply	other threads:[~2023-03-24 14:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 14:04 Felix Fietkau [this message]
2023-03-25  9:28 ` Aw: [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links Frank Wunderlich
2023-03-26 15:56   ` Felix Fietkau
2023-03-26 17:10     ` Aw: " Frank Wunderlich
2023-03-26 17:27       ` Felix Fietkau
2023-03-26 17:49         ` Aw: " Frank Wunderlich
2023-03-26 20:09           ` Felix Fietkau
2023-03-27 17:28             ` Aw: " Frank Wunderlich
2023-03-29  7:48               ` Felix Fietkau
2023-03-29 12:04               ` Felix Fietkau
2023-03-30 13:58                 ` Aw: " Frank Wunderlich
2023-03-30 17:06                   ` Felix Fietkau
2023-03-31 12:46                     ` Aw: " Frank Wunderlich
2023-03-29  2:01 ` Jakub Kicinski
2023-03-29  4:54   ` Felix Fietkau
2023-03-29  6:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324140404.95745-1-nbd@nbd.name \
    --to=nbd@nbd.name \
    --cc=daniel@makrotopia.org \
    --cc=frank-w@public-files.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).