[PATCH net-next v4] tools: ynl: Add missing types to encode/decode

[PATCH net-next v4] tools: ynl: Add missing types to encode/decode

[Michal Michalik]

While testing the tool I noticed we miss the u16 type on payload create.
On the code inspection it turned out we miss also u64 - add them.

We also miss the decoding of u16 despite the fact `NlAttr` class
supports it - add it.

Signed-off-by: Michal Michalik <michal.michalik@intel.com>
--
v4:
- remove `Fixes:` tag since no code is using that now
- rebased to latest tree
v3: change tree `net` -> `net-next`
v2: add a `Fixes:` tag to the commit message
---
 tools/net/ynl/lib/ynl.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
index bcb798c..788f130 100644
--- a/tools/net/ynl/lib/ynl.py
+++ b/tools/net/ynl/lib/ynl.py
@@ -336,8 +336,12 @@ class YnlFamily(SpecFamily):
             attr_payload = b''
         elif attr["type"] == 'u8':
             attr_payload = struct.pack("B", int(value))
+        elif attr["type"] == 'u16':
+            attr_payload = struct.pack("H", int(value))
         elif attr["type"] == 'u32':
             attr_payload = struct.pack("I", int(value))
+        elif attr["type"] == 'u64':
+            attr_payload = struct.pack("Q", int(value))
         elif attr["type"] == 'string':
             attr_payload = str(value).encode('ascii') + b'\x00'
         elif attr["type"] == 'binary':
@@ -373,6 +377,8 @@ class YnlFamily(SpecFamily):
                 decoded = subdict
             elif attr_spec['type'] == 'u8':
                 decoded = attr.as_u8()
+            elif attr_spec['type'] == 'u16':
+                decoded = attr.as_u16()
             elif attr_spec['type'] == 'u32':
                 decoded = attr.as_u32()
             elif attr_spec['type'] == 'u64':
-- 
2.9.5

base-commit: 323fe43cf9aef79159ba8937218a3f076bf505af

Re: [PATCH net-next v4] tools: ynl: Add missing types to encode/decode

[Jakub Kicinski]

On Fri, 24 Mar 2023 18:52:58 +0100 Michal Michalik wrote:
> While testing the tool I noticed we miss the u16 type on payload create.
> On the code inspection it turned out we miss also u64 - add them.
> 
> We also miss the decoding of u16 despite the fact `NlAttr` class
> supports it - add it.
> 
> Signed-off-by: Michal Michalik <michal.michalik@intel.com>

Acked-by: Jakub Kicinski <kuba@kernel.org>

Re: [PATCH net-next v4] tools: ynl: Add missing types to encode/decode

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 24 Mar 2023 18:52:58 +0100 you wrote:
> While testing the tool I noticed we miss the u16 type on payload create.
> On the code inspection it turned out we miss also u64 - add them.
> 
> We also miss the decoding of u16 despite the fact `NlAttr` class
> supports it - add it.
> 
> Signed-off-by: Michal Michalik <michal.michalik@intel.com>
> --
> v4:
> - remove `Fixes:` tag since no code is using that now
> - rebased to latest tree
> v3: change tree `net` -> `net-next`
> v2: add a `Fixes:` tag to the commit message
> 
> [...]

Here is the summary with links:
  - [net-next,v4] tools: ynl: Add missing types to encode/decode
    https://git.kernel.org/netdev/net-next/c/dd3a7d58dcc2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html