From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A951C76195 for ; Fri, 24 Mar 2023 23:14:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232321AbjCXXOM (ORCPT ); Fri, 24 Mar 2023 19:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbjCXXOF (ORCPT ); Fri, 24 Mar 2023 19:14:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEBAF1E1D9 for ; Fri, 24 Mar 2023 16:13:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 68B0CB82662 for ; Fri, 24 Mar 2023 23:13:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A20DC4339B; Fri, 24 Mar 2023 23:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679699635; bh=1sjJusr5d747AN+IuI7iwpxpeDyv0U46C5gRi54lnkE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RZfwvulDaNuECJXgLSnGErnf0MV+1vDO1mPkqbMEiN3aqBD0Y1EGgZnmnUPXjMrgd G/fL0ejzDPMlYgPbr72ILitL8+c4JeuEusENmCHk24FgBGM7TY4gEqdNF5oxeHcE0d Sf+lqcpyQkQyLLLyjYDyr8XUVSM5JBN5CHjx/g+rd6xXzwAJLoXStoB1flociL7pjh UqipnSoUJK9wK1/Og4gCuluq96fAmTt5PzyeWxkwZGox9mQ2wWu1QEwYxDDQYNiBID dlzqfefuiZQ2k3m9s+x6HscjIEvXM4bkHqLJhuz7+lWFWH9MKJ7HA14S6wRyJ7f5LK rFaXs78/oETAA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Thomas Gleixner , Eli Cohen , Shay Drory , Jacob Keller Subject: [net-next V2 05/15] net/mlx5: Fix wrong comment Date: Fri, 24 Mar 2023 16:13:31 -0700 Message-Id: <20230324231341.29808-6-saeed@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230324231341.29808-1-saeed@kernel.org> References: <20230324231341.29808-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eli Cohen A control irq may be allocated from the parent device's pool in case there is no SF dedicated pool. This could happen when there are not enough vectors available for SFs. Signed-off-by: Eli Cohen Reviewed-by: Shay Drory Signed-off-by: Saeed Mahameed Reviewed-by: Jacob Keller --- drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c index 6bde18bcd42f..c72736f1571f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c @@ -394,7 +394,9 @@ struct mlx5_irq *mlx5_ctrl_irq_request(struct mlx5_core_dev *dev) return ERR_PTR(-ENOMEM); cpumask_copy(req_mask, cpu_online_mask); if (!mlx5_irq_pool_is_sf_pool(pool)) { - /* In case we are allocating a control IRQ for PF/VF */ + /* In case we are allocating a control IRQ from a pci device's pool. + * This can happen also for a SF if the SFs pool is empty. + */ if (!pool->xa_num_irqs.max) { cpumask_clear(req_mask); /* In case we only have a single IRQ for PF/VF */ -- 2.39.2