From: Vladimir Oltean <olteanv@gmail.com>
To: Russell King <linux@armlinux.org.uk>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Marek Vasut <marex@denx.de>,
Oleksij Rempel <linux@rempel-privat.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Ben Hutchings <ben.hutchings@mind.be>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT PATCH net-next 2/4] net: dsa: microchip: partial conversion to regfields API for KSZ8795 (WIP)
Date: Sat, 25 Mar 2023 14:16:55 +0200 [thread overview]
Message-ID: <20230325121655.oz3afcempaaniqc4@skbuf> (raw)
In-Reply-To: <20230317140722.wtobrtpgazutykaj@skbuf>
On Fri, Mar 17, 2023 at 04:07:22PM +0200, Vladimir Oltean wrote:
> On Fri, Mar 17, 2023 at 02:21:40PM +0100, Oleksij Rempel wrote:
> > If you'll give up, may be i'll be able to take it over.
>
> I have not given up yet, I just need someone to run a few tests on KSZ8795.
Seeing that the first line of people (able to test on KSZ8795) has no
opinion, maybe it's time to turn to the second line of people.
Russell, you've expressed that this driver is "vile" for permitting
access to the same hardware register through 2 different ksz8795_regs[]
elements. Does the approach used in this patch set address your concerns,
or in other words, do you believe is it worth extending the conversion
to the KSZ switches that other people can test, such that the entire
driver ultimately benefits from the conversion?
next prev parent reply other threads:[~2023-03-25 12:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 16:12 [RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg_fields conversion Vladimir Oltean
2023-03-16 16:12 ` [RFC/RFT PATCH net-next 1/4] net: dsa: microchip: add an enum for regmap widths Vladimir Oltean
2023-03-16 16:12 ` [RFC/RFT PATCH net-next 2/4] net: dsa: microchip: partial conversion to regfields API for KSZ8795 (WIP) Vladimir Oltean
2023-03-17 9:46 ` Vladimir Oltean
2023-03-17 11:46 ` Oleksij Rempel
2023-03-17 12:50 ` Vladimir Oltean
2023-03-17 13:21 ` Oleksij Rempel
2023-03-17 14:07 ` Vladimir Oltean
2023-03-25 12:16 ` Vladimir Oltean [this message]
2023-03-25 14:26 ` Russell King (Oracle)
2023-03-16 16:12 ` [RFC/RFT PATCH net-next 3/4] net: dsa: microchip: allow setting xMII port speed/duplex on KSZ8765/KSZ8794/KSZ8795 Vladimir Oltean
2023-03-16 16:12 ` [RFC/RFT PATCH net-next 4/4] net: dsa: microchip: remove unused dev->dev_ops->phylink_mac_config() Vladimir Oltean
2023-03-17 3:57 ` [RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg_fields conversion Arun.Ramadoss
2023-03-17 6:02 ` Oleksij Rempel
2023-03-17 9:43 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325121655.oz3afcempaaniqc4@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=ben.hutchings@mind.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=m.grzeschik@pengutronix.de \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox