* [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable
@ 2023-03-27 23:54 Tom Rix
2023-03-28 17:57 ` Simon Horman
2023-03-29 7:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-27 23:54 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
int xfer_count = count;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/8390/axnet_cs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c
index 3aef959fc25b..78f985885547 100644
--- a/drivers/net/ethernet/8390/axnet_cs.c
+++ b/drivers/net/ethernet/8390/axnet_cs.c
@@ -650,7 +650,6 @@ static void block_input(struct net_device *dev, int count,
{
unsigned int nic_base = dev->base_addr;
struct ei_device *ei_local = netdev_priv(dev);
- int xfer_count = count;
char *buf = skb->data;
if ((netif_msg_rx_status(ei_local)) && (count != 4))
@@ -662,9 +661,7 @@ static void block_input(struct net_device *dev, int count,
insw(nic_base + AXNET_DATAPORT,buf,count>>1);
if (count & 0x01) {
buf[count-1] = inb(nic_base + AXNET_DATAPORT);
- xfer_count++;
}
-
}
/*====================================================================*/
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable
2023-03-27 23:54 [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable Tom Rix
@ 2023-03-28 17:57 ` Simon Horman
2023-03-29 7:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-28 17:57 UTC (permalink / raw)
To: Tom Rix
Cc: davem, edumazet, kuba, pabeni, nathan, ndesaulniers, netdev,
linux-kernel, llvm
On Mon, Mar 27, 2023 at 07:54:23PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
> 'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
> int xfer_count = count;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable
2023-03-27 23:54 [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable Tom Rix
2023-03-28 17:57 ` Simon Horman
@ 2023-03-29 7:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-29 7:00 UTC (permalink / raw)
To: Tom Rix
Cc: davem, edumazet, kuba, pabeni, nathan, ndesaulniers, netdev,
linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 27 Mar 2023 19:54:23 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/8390/axnet_cs.c:653:9: error: variable
> 'xfer_count' set but not used [-Werror,-Wunused-but-set-variable]
> int xfer_count = count;
> ^
> This variable is not used so remove it.
>
> [...]
Here is the summary with links:
- net: ethernet: 8390: axnet_cs: remove unused xfer_count variable
https://git.kernel.org/netdev/net-next/c/e48cefb9c8d1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-29 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-27 23:54 [PATCH] net: ethernet: 8390: axnet_cs: remove unused xfer_count variable Tom Rix
2023-03-28 17:57 ` Simon Horman
2023-03-29 7:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).