From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313C8C76195 for ; Tue, 28 Mar 2023 10:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231509AbjC1KtL (ORCPT ); Tue, 28 Mar 2023 06:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230380AbjC1KtK (ORCPT ); Tue, 28 Mar 2023 06:49:10 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23DA6183; Tue, 28 Mar 2023 03:49:08 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A5429240002; Tue, 28 Mar 2023 10:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680000547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YcAVZxrol8sJCDpLcTmeIdWOWavc1Uiq8RyPwQ5WwwE=; b=md988PTmh5TlAklTAHKZjQyEBHowcSxi5+GbphBOtqRbyFiG0KziKyv+ykf3lBl3tLEVcz FTYP/ojqNXXOIZ1HD8ChM4f2A0kp1qnOjLnOdGh61r0ecwlQzvK93aINomHWm1GfcU76IA EtNI9Wi2fHwEDXkPVttytjNgB9j9Ka3zTit/THwB5di9o5Spn4FlDQw9QE/Q/J38Ikoprw v1EdOMPNOi9NJ/AWbVizUIU91pMDFeFVCQyTi1CicdSmITSVNJ0zP/0YCjJfvjfFS8cSbs 2tdopXaYj62KoOO9pJrddI+ciTSsM0HmK/q/3lglJtPwBIM6+ZNGs/0mLzCnIw== Date: Tue, 28 Mar 2023 12:48:59 +0200 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Claudiu Manoil , Alexandre Belloni , Colin Foster , Michael Hennerich , Alexander Aring , Stefan Schmidt , Heiner Kallweit , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org Subject: Re: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table Message-ID: <20230328124859.12f3c329@xps-13> In-Reply-To: <20230311173303.262618-7-krzysztof.kozlowski@linaro.org> References: <20230311173303.262618-1-krzysztof.kozlowski@linaro.org> <20230311173303.262618-7-krzysztof.kozlowski@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Krzysztof, krzysztof.kozlowski@linaro.org wrote on Sat, 11 Mar 2023 18:32:58 +0100: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). >=20 > drivers/net/ieee802154/adf7242.c:1322:34: error: =E2=80=98adf7242_of_ma= tch=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski I see Stefan already acked most of the ieee802154 patches, but I didn't got notified for this one, so in case: Acked-by: Miquel Raynal > --- > drivers/net/ieee802154/adf7242.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/ad= f7242.c > index 5cf218c674a5..509acc86001c 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); > static struct spi_driver adf7242_driver =3D { > .id_table =3D adf7242_device_id, > .driver =3D { > - .of_match_table =3D of_match_ptr(adf7242_of_match), > + .of_match_table =3D adf7242_of_match, > .name =3D "adf7242", > .owner =3D THIS_MODULE, > }, Thanks, Miqu=C3=A8l