From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37EA6C76196 for ; Tue, 28 Mar 2023 14:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233312AbjC1OsS (ORCPT ); Tue, 28 Mar 2023 10:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233306AbjC1OsK (ORCPT ); Tue, 28 Mar 2023 10:48:10 -0400 Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46BA1DBCC; Tue, 28 Mar 2023 07:47:47 -0700 (PDT) Received: from kandell (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id AB3451C147B; Tue, 28 Mar 2023 16:47:42 +0200 (CEST) Authentication-Results: mail.nic.cz; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1680014864; bh=8gvfVWSHMDuNvvsDwY1HViDWLctRRNs/Urhm0s1QuW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Reply-To: Subject:To:Cc; b=uQI/uAEr7SG+opneRJoqPCCRfUsWk8gV9U8WrjVC1sz/xUr81EoKBqtCgKdjYsgY2 XFfPX7JSOehb4xadeFXIb2Uw7QUjtr9sbM02dlOZzfAkTHDhxwvbdmEH3yHxdiPhiv kCv/0J5dGXSJr1RuPW0RRhN5ekxh7O0fTWTRXG2o= Date: Tue, 28 Mar 2023 16:47:42 +0200 From: Marek =?utf-8?B?QmVow7pu?= To: Andrew Lunn Cc: Gustav Ekelund , Gustav Ekelund , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Reset mv88e6393x watchdog register Message-ID: <20230328144742.vty3cpmgmsdyjiia@kandell> References: <20230328115511.400145-1-gustav.ekelund@axis.com> <20230328120604.zawfeskqs4yhlze6@kandell> <9ba1722a-8dd7-4d6d-bade-b4c702c8387f@lunn.ch> <20230328124754.oscahd3wtod6vkfy@kandell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.7 at mail X-Virus-Status: Clean X-Spamd-Bar: / X-Spamd-Result: default: False [-0.10 / 20.00]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; WHITELISTED_IP(0.00)[172.20.6.87]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+] X-Rspamd-Queue-Id: AB3451C147B X-Rspamd-Action: no action X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: WHITELISTED_IP X-Rspamd-Server: mail Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 28, 2023 at 03:45:51PM +0200, Andrew Lunn wrote: > On Tue, Mar 28, 2023 at 03:34:03PM +0200, Gustav Ekelund wrote: > > > 1) Marvell has confirmed that 6393x (Amethyst) differs from 6390 (Peridot) > > with quote: “I tried this on my board and see G2 offset 0x1B index 12 bit 0 > > does not clear, I also tried doing a SWReset and the bit is still 1. I did > > try the same on a Peridot board and it clears as advertised.” > > > > 2) Marvell are not aware of any other stuck bits, but has confirmed that the > > WD event bits are not cleared on SW reset which is indeed contradictory to > > what the data sheet suggests. > > Hi Gustav > > Please expand the commit message with a summary of this > information. It answers the questions both Marek and i have been > asking, so deserves to be in the commit message. > > Andrew Maybe also add a comment next to the code writing to the register, that this is due to an yet unreleased erratum on 6393x. Marek