From: Jakub Kicinski <kuba@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: netdev@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links
Date: Tue, 28 Mar 2023 19:01:55 -0700 [thread overview]
Message-ID: <20230328190155.7eab8368@kernel.org> (raw)
In-Reply-To: <20230324140404.95745-1-nbd@nbd.name>
On Fri, 24 Mar 2023 15:04:04 +0100 Felix Fietkau wrote:
> Using the QDMA tx scheduler to throttle tx to line speed works fine for
> switch ports, but apparently caused a regression on non-switch ports.
>
> Based on a number of tests, it seems that this throttling can be safely
> dropped without re-introducing the issues on switch ports that the
> tx scheduling changes resolved.
>
> Link: https://lore.kernel.org/netdev/trinity-92c3826f-c2c8-40af-8339-bc6d0d3ffea4-1678213958520@3c-app-gmx-bs16/
> Fixes: f63959c7eec3 ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues")
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Reported-by: Daniel Golle <daniel@makrotopia.org>
> Tested-by: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
My reading of the discussion was that this patch is good, even if it
doesn't fix all the models, but it's marked as Changes Requested in PW.
Could you confirm that we should apply this one as is, just to be sure?
next prev parent reply other threads:[~2023-03-29 2:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 14:04 [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links Felix Fietkau
2023-03-25 9:28 ` Aw: " Frank Wunderlich
2023-03-26 15:56 ` Felix Fietkau
2023-03-26 17:10 ` Aw: " Frank Wunderlich
2023-03-26 17:27 ` Felix Fietkau
2023-03-26 17:49 ` Aw: " Frank Wunderlich
2023-03-26 20:09 ` Felix Fietkau
2023-03-27 17:28 ` Aw: " Frank Wunderlich
2023-03-29 7:48 ` Felix Fietkau
2023-03-29 12:04 ` Felix Fietkau
2023-03-30 13:58 ` Aw: " Frank Wunderlich
2023-03-30 17:06 ` Felix Fietkau
2023-03-31 12:46 ` Aw: " Frank Wunderlich
2023-03-29 2:01 ` Jakub Kicinski [this message]
2023-03-29 4:54 ` Felix Fietkau
2023-03-29 6:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328190155.7eab8368@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@makrotopia.org \
--cc=frank-w@public-files.de \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).