From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: "Saeed Mahameed" <saeedm@nvidia.com>,
netdev@vger.kernel.org, "Tariq Toukan" <tariqt@nvidia.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Dragos Tatulea" <dtatulea@nvidia.com>
Subject: [net-next 08/15] net/mlx5e: RX, Rename xdp_xmit_bitmap to a more generic name
Date: Tue, 28 Mar 2023 13:56:16 -0700 [thread overview]
Message-ID: <20230328205623.142075-9-saeed@kernel.org> (raw)
In-Reply-To: <20230328205623.142075-1-saeed@kernel.org>
From: Dragos Tatulea <dtatulea@nvidia.com>
The xdp_xmit_bitmap currently serves only one purpose: to avoid
releasing pages that are still in use due to XDP TX.
A following patch will use this bitmap in a slightly different context
but for the same purpose. So rename the bitmap to a more generic name
that reflects the purpose not the context.
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 4 ++--
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index 0862556105d5..566ddf7a7aa9 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -622,7 +622,7 @@ union mlx5e_alloc_units {
struct mlx5e_mpw_info {
u16 consumed_strides;
- DECLARE_BITMAP(xdp_xmit_bitmap, MLX5_MPWRQ_MAX_PAGES_PER_WQE);
+ DECLARE_BITMAP(skip_release_bitmap, MLX5_MPWRQ_MAX_PAGES_PER_WQE);
union mlx5e_alloc_units alloc_units;
};
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
index b2c1af07c317..3cde264cbe4e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
@@ -120,7 +120,7 @@ int mlx5e_xsk_alloc_rx_mpwqe(struct mlx5e_rq *rq, u16 ix)
}
}
- bitmap_zero(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
+ bitmap_zero(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
wi->consumed_strides = 0;
umr_wqe->ctrl.opmod_idx_opcode =
@@ -289,7 +289,7 @@ struct sk_buff *mlx5e_xsk_skb_from_cqe_mpwrq_linear(struct mlx5e_rq *rq,
prog = rcu_dereference(rq->xdp_prog);
if (likely(prog && mlx5e_xdp_handle(rq, prog, mxbuf))) {
if (likely(__test_and_clear_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags)))
- __set_bit(page_idx, wi->xdp_xmit_bitmap); /* non-atomic */
+ __set_bit(page_idx, wi->skip_release_bitmap); /* non-atomic */
return NULL; /* page/packet was consumed by XDP */
}
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
index 7724e30ec133..eab8cba33ce4 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
@@ -439,10 +439,10 @@ mlx5e_free_rx_mpwqe(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi, bool recycle
int i;
/* A common case for AF_XDP. */
- if (bitmap_full(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe))
+ if (bitmap_full(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe))
return;
- no_xdp_xmit = bitmap_empty(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
+ no_xdp_xmit = bitmap_empty(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
if (rq->xsk_pool) {
struct xdp_buff **xsk_buffs = wi->alloc_units.xsk_buffs;
@@ -452,11 +452,11 @@ mlx5e_free_rx_mpwqe(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi, bool recycle
* the page to the userspace when the interface goes down.
*/
for (i = 0; i < rq->mpwqe.pages_per_wqe; i++)
- if (no_xdp_xmit || !test_bit(i, wi->xdp_xmit_bitmap))
+ if (no_xdp_xmit || !test_bit(i, wi->skip_release_bitmap))
xsk_buff_free(xsk_buffs[i]);
} else {
for (i = 0; i < rq->mpwqe.pages_per_wqe; i++) {
- if (no_xdp_xmit || !test_bit(i, wi->xdp_xmit_bitmap)) {
+ if (no_xdp_xmit || !test_bit(i, wi->skip_release_bitmap)) {
struct mlx5e_frag_page *frag_page;
frag_page = &wi->alloc_units.frag_pages[i];
@@ -687,7 +687,7 @@ static int mlx5e_alloc_rx_mpwqe(struct mlx5e_rq *rq, u16 ix)
sizeof(*umr_wqe->inline_mtts) * pad);
}
- bitmap_zero(wi->xdp_xmit_bitmap, rq->mpwqe.pages_per_wqe);
+ bitmap_zero(wi->skip_release_bitmap, rq->mpwqe.pages_per_wqe);
wi->consumed_strides = 0;
umr_wqe->ctrl.opmod_idx_opcode =
@@ -1970,7 +1970,7 @@ mlx5e_skb_from_cqe_mpwrq_linear(struct mlx5e_rq *rq, struct mlx5e_mpw_info *wi,
mlx5e_fill_mxbuf(rq, cqe, va, rx_headroom, cqe_bcnt, &mxbuf);
if (mlx5e_xdp_handle(rq, prog, &mxbuf)) {
if (__test_and_clear_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags))
- __set_bit(page_idx, wi->xdp_xmit_bitmap); /* non-atomic */
+ __set_bit(page_idx, wi->skip_release_bitmap); /* non-atomic */
return NULL; /* page/packet was consumed by XDP */
}
--
2.39.2
next prev parent reply other threads:[~2023-03-28 20:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 20:56 [pull request][net-next 00/15] mlx5: Drop internal page cache implementation Saeed Mahameed
2023-03-28 20:56 ` [net-next 01/15] net/mlx5e: RX, Remove mlx5e_alloc_unit argument in page allocation Saeed Mahameed
2023-03-30 5:20 ` patchwork-bot+netdevbpf
2023-03-28 20:56 ` [net-next 02/15] net/mlx5e: RX, Remove alloc unit layout constraint for legacy rq Saeed Mahameed
2023-03-28 20:56 ` [net-next 03/15] net/mlx5e: RX, Remove alloc unit layout constraint for striding rq Saeed Mahameed
2023-03-28 20:56 ` [net-next 04/15] net/mlx5e: RX, Store SHAMPO header pages in array Saeed Mahameed
2023-03-28 20:56 ` [net-next 05/15] net/mlx5e: RX, Remove internal page_cache Saeed Mahameed
2023-03-28 20:56 ` [net-next 06/15] net/mlx5e: RX, Enable dma map and sync from page_pool allocator Saeed Mahameed
2023-03-28 20:56 ` [net-next 07/15] net/mlx5e: RX, Enable skb page recycling through the page_pool Saeed Mahameed
2023-03-28 20:56 ` Saeed Mahameed [this message]
2023-03-28 20:56 ` [net-next 09/15] net/mlx5e: RX, Defer page release in striding rq for better recycling Saeed Mahameed
2023-03-28 20:56 ` [net-next 10/15] net/mlx5e: RX, Change wqe last_in_page field from bool to bit flags Saeed Mahameed
2023-03-28 20:56 ` [net-next 11/15] net/mlx5e: RX, Defer page release in legacy rq for better recycling Saeed Mahameed
2023-03-28 20:56 ` [net-next 12/15] net/mlx5e: RX, Split off release path for xsk buffers for legacy rq Saeed Mahameed
2023-03-28 20:56 ` [net-next 13/15] net/mlx5e: RX, Increase WQE bulk size " Saeed Mahameed
2023-03-28 20:56 ` [net-next 14/15] net/mlx5e: RX, Break the wqe bulk refill in smaller chunks Saeed Mahameed
2023-03-28 20:56 ` [net-next 15/15] net/mlx5e: RX, Remove unnecessary recycle parameter and page_cache stats Saeed Mahameed
2023-03-29 15:12 ` [pull request][net-next 00/15] mlx5: Drop internal page cache implementation Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328205623.142075-9-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).