From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, bpf@vger.kernel.org,
Piotr Raczynski <piotr.raczynski@intel.com>
Subject: Re: [PATCH net 1/4] ice: fix W=1 headers mismatch
Date: Wed, 29 Mar 2023 15:06:44 +0300 [thread overview]
Message-ID: <20230329120644.GP831478@unreal> (raw)
In-Reply-To: <20230328172035.3904953-2-anthony.l.nguyen@intel.com>
On Tue, Mar 28, 2023 at 10:20:32AM -0700, Tony Nguyen wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> make modules W=1 returns:
> .../ice/ice_txrx_lib.c:448: warning: Function parameter or member 'first_idx' not described in 'ice_finalize_xdp_rx'
> .../ice/ice_txrx.c:948: warning: Function parameter or member 'ntc' not described in 'ice_get_rx_buf'
> .../ice/ice_txrx.c:1038: warning: Excess function parameter 'rx_buf' description in 'ice_construct_skb'
>
> Fix these warnings by adding and deleting the deviant arguments.
>
> Fixes: 2fba7dc5157b ("ice: Add support for XDP multi-buffer on Rx side")
> Fixes: d7956d81f150 ("ice: Pull out next_to_clean bump out of ice_put_rx_buf()")
> CC: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-03-29 12:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:20 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2023-03-28 (ice) Tony Nguyen
2023-03-28 17:20 ` [PATCH net 1/4] ice: fix W=1 headers mismatch Tony Nguyen
2023-03-29 12:06 ` Leon Romanovsky [this message]
2023-03-28 17:20 ` [PATCH net 2/4] ice: Fix ice_cfg_rdma_fltr() to only update relevant fields Tony Nguyen
2023-03-29 12:08 ` Leon Romanovsky
2023-03-28 17:20 ` [PATCH net 3/4] ice: add profile conflict check for AVF FDIR Tony Nguyen
2023-03-29 12:08 ` Leon Romanovsky
2023-03-28 17:20 ` [PATCH net 4/4] ice: fix invalid check for empty list in ice_sched_assoc_vsi_to_agg() Tony Nguyen
2023-03-29 12:08 ` Leon Romanovsky
2023-03-30 4:50 ` [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2023-03-28 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329120644.GP831478@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.raczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).