From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Radoslaw Tyl <radoslawx.tyl@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Arpana Arland <arpanax.arland@intel.com>
Subject: Re: [PATCH net 1/1] i40e: fix registers dump after run ethtool adapter self test
Date: Wed, 29 Mar 2023 15:09:22 +0300 [thread overview]
Message-ID: <20230329120922.GT831478@unreal> (raw)
In-Reply-To: <20230328172659.3906413-1-anthony.l.nguyen@intel.com>
On Tue, Mar 28, 2023 at 10:26:59AM -0700, Tony Nguyen wrote:
> From: Radoslaw Tyl <radoslawx.tyl@intel.com>
>
> Fix invalid registers dump from ethtool -d ethX after adapter self test
> by ethtool -t ethY. It causes invalid data display.
>
> The problem was caused by overwriting i40e_reg_list[].elements
> which is common for ethtool self test and dump.
>
> Fixes: 22dd9ae8afcc ("i40e: Rework register diagnostic")
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_diag.c | 11 ++++++-----
> drivers/net/ethernet/intel/i40e/i40e_diag.h | 2 +-
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-03-29 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:26 [PATCH net 1/1] i40e: fix registers dump after run ethtool adapter self test Tony Nguyen
2023-03-29 12:09 ` Leon Romanovsky [this message]
2023-03-30 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329120922.GT831478@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=arpanax.arland@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radoslawx.tyl@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).