From: Leon Romanovsky <leon@kernel.org>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, sd@queasysnail.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/4] Support MACsec VLAN
Date: Wed, 29 Mar 2023 21:37:32 +0300 [thread overview]
Message-ID: <20230329183732.GA831478@unreal> (raw)
In-Reply-To: <20230329122107.22658-1-ehakim@nvidia.com>
On Wed, Mar 29, 2023 at 03:21:03PM +0300, Emeel Hakim wrote:
> Dear maintainers,
>
> This patch series introduces support for hardware (HW) offload MACsec
> devices with VLAN configuration. The patches address both scenarios
> where the VLAN header is both the inner and outer header for MACsec.
>
> The changes include:
>
> 1. Adding MACsec offload operation for VLAN.
> 2. Considering VLAN when accessing MACsec net device.
> 3. Currently offloading MACsec when it's configured over VLAN with
> current MACsec TX steering rules would wrongly insert the MACsec sec tag
> after inserting the VLAN header. This resulted in an ETHERNET | SECTAG |
> VLAN packet when ETHERNET | VLAN | SECTAG is configured. The patche
> handles this issue when configuring steering rules.
> 4. Adding MACsec rx_handler change support in case of a marked skb and a
> mismatch on the dst MAC address.
>
> Please review these changes and let me know if you have any feedback or
> concerns.
>
> Updates since v1:
> - Consult vlan_features when adding NETIF_F_HW_MACSEC.
> - Allow grep for the functions.
> - Add helper function to get the macsec operation to allow the compiler
> to make some choice.
Please mark all your patches as vXXX and not only one.
Thanks
prev parent reply other threads:[~2023-03-29 18:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 12:21 [PATCH net-next v2 0/4] Support MACsec VLAN Emeel Hakim
2023-03-29 12:21 ` [PATCH net-next v2 1/4] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-03-29 14:43 ` Sabrina Dubroca
2023-03-29 18:42 ` Leon Romanovsky
2023-03-30 17:19 ` Sabrina Dubroca
2023-03-30 17:42 ` Jakub Kicinski
2023-03-31 14:33 ` Emeel Hakim
2023-03-30 18:56 ` Leon Romanovsky
2023-03-30 20:32 ` Sabrina Dubroca
2023-04-03 9:29 ` Emeel Hakim
2023-04-04 12:53 ` Sabrina Dubroca
2023-04-04 14:37 ` Emeel Hakim
2023-04-05 9:35 ` Sabrina Dubroca
2023-04-05 9:27 ` Sabrina Dubroca
2023-04-05 9:36 ` Emeel Hakim
2023-03-29 12:21 ` [PATCH net-next 2/4] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-03-29 12:21 ` [PATCH net-next 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-03-29 12:21 ` [PATCH net-next 4/4] macsec: Add MACsec rx_handler change support Emeel Hakim
2023-04-05 9:35 ` Sabrina Dubroca
2023-04-05 9:41 ` Emeel Hakim
2023-03-29 18:37 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329183732.GA831478@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).