From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Louis Peens <louis.peens@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>
Subject: Re: [PATCH net-next 2/2] nfp: separate the port's upper state with lower phy state
Date: Wed, 29 Mar 2023 21:00:48 -0700 [thread overview]
Message-ID: <20230329210048.0054e01b@kernel.org> (raw)
In-Reply-To: <DM6PR13MB37058BF030C43EAFA45DE4CAFC8E9@DM6PR13MB3705.namprd13.prod.outlook.com>
On Thu, 30 Mar 2023 03:33:30 +0000 Yinjun Zhang wrote:
> > Why?
>
> I have to say most of other vendors behave like this. It's more practical
> and required by users.
That's not really a practical explanation. Why does anyone want traffic
to flow thru a downed port. Don't down the port, if you want it to be
up, I'd think.
This patch is very unlikely to be accepted upstream.
Custom knobs to do weird things are really not our favorite.
next prev parent reply other threads:[~2023-03-30 4:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 14:45 [PATCH net-next 0/2] Small series of enhancements Louis Peens
2023-03-29 14:45 ` [PATCH net-next 1/2] nfp: initialize netdev's dev_port with correct id Louis Peens
2023-03-29 18:49 ` Leon Romanovsky
2023-03-30 1:32 ` Yinjun Zhang
2023-03-29 19:22 ` Jakub Kicinski
2023-03-30 1:40 ` Yinjun Zhang
2023-03-30 2:38 ` Jakub Kicinski
2023-03-30 2:52 ` Yinjun Zhang
2023-03-30 3:10 ` Jakub Kicinski
2023-03-30 3:27 ` Yinjun Zhang
2023-03-30 3:58 ` Jakub Kicinski
2023-03-29 14:45 ` [PATCH net-next 2/2] nfp: separate the port's upper state with lower phy state Louis Peens
2023-03-29 18:52 ` Leon Romanovsky
2023-03-30 1:48 ` Yinjun Zhang
2023-03-29 19:24 ` Jakub Kicinski
2023-03-30 1:56 ` Yinjun Zhang
2023-03-30 2:41 ` Jakub Kicinski
2023-03-30 2:57 ` Yinjun Zhang
2023-03-30 3:12 ` Jakub Kicinski
2023-03-30 3:33 ` Yinjun Zhang
2023-03-30 4:00 ` Jakub Kicinski [this message]
2023-03-30 5:55 ` Yinjun Zhang
2023-03-30 17:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329210048.0054e01b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).