From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jonathan Toppins <jtoppins@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] bonding: add software timestamping support
Date: Wed, 29 Mar 2023 21:07:59 -0700 [thread overview]
Message-ID: <20230329210759.1a8f9df4@kernel.org> (raw)
In-Reply-To: <ZCUDFyNQoulZRsRQ@Laptop-X1>
On Thu, 30 Mar 2023 11:33:43 +0800 Hangbin Liu wrote:
> On Wed, Mar 29, 2023 at 12:27:11PM +0200, Miroslav Lichvar wrote:
> > On Wed, Mar 29, 2023 at 11:13:37AM +0800, Hangbin Liu wrote:
> > > At present, bonding attempts to obtain the timestamp (ts) information of
> > > the active slave. However, this feature is only available for mode 1, 5,
> > > and 6. For other modes, bonding doesn't even provide support for software
> > > timestamping. To address this issue, let's call ethtool_op_get_ts_info
> > > when there is no primary active slave. This will enable the use of software
> > > timestamping for the bonding interface.
> >
> > Would it make sense to check if all devices in the bond support
> > SOF_TIMESTAMPING_TX_SOFTWARE before returning it for the bond?
> > Applications might expect that a SW TX timestamp will be always
> > provided if the capability is reported.
>
> In my understanding this is a software feature, no need for hardware support.
> In __sock_tx_timestamp() it will set skb tx_flags when we have
> SOF_TIMESTAMPING_TX_SOFTWARE flag. Do I understand wrong?
Driver needs to call skb_tx_timestamp(), so unlike with Rx there's
something to do for the driver.
next prev parent reply other threads:[~2023-03-30 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 3:13 [PATCH net-next] bonding: add software timestamping support Hangbin Liu
2023-03-29 3:36 ` Jay Vosburgh
2023-03-30 4:01 ` Hangbin Liu
2023-03-30 4:39 ` Jay Vosburgh
2023-03-29 10:27 ` Miroslav Lichvar
2023-03-30 3:33 ` Hangbin Liu
2023-03-30 4:07 ` Jakub Kicinski [this message]
2023-03-30 4:12 ` Jay Vosburgh
2023-03-31 3:32 ` Hangbin Liu
2023-04-03 10:18 ` Miroslav Lichvar
2023-04-05 9:04 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329210759.1a8f9df4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).