From: Jakub Kicinski <kuba@kernel.org>
To: Sricharan R <quic_srichara@quicinc.com>
Cc: <mani@kernel.org>, <manivannan.sadhasivam@linaro.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT
Date: Wed, 29 Mar 2023 21:32:16 -0700 [thread overview]
Message-ID: <20230329213216.7b0447e9@kernel.org> (raw)
In-Reply-To: <1680095250-21032-1-git-send-email-quic_srichara@quicinc.com>
On Wed, 29 Mar 2023 18:37:30 +0530 Sricharan R wrote:
> When the qrtr socket is released, qrtr_port_remove gets called, which
> broadcasts a DEL_CLIENT. After this DEL_SERVER is also additionally
> broadcasted, which becomes NOP, but triggers the below error msg.
>
> "failed while handling packet from 2:-2", since remote node already
> acted upon on receiving the DEL_CLIENT, once again when it receives
> the DEL_SERVER, it returns -ENOENT.
>
> Fixing it by not sending a 'DEL_SERVER' to remote when a 'DEL_CLIENT'
> was sent for that port.
You use the word "fix" so please add a Fixes tag.
> Signed-off-by: Ram Kumar D <quic_ramd@quicinc.com>
> Signed-off-by: Sricharan R <quic_srichara@quicinc.com>
Spell out full names, please.
next prev parent reply other threads:[~2023-03-30 4:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 13:07 [PATCH] net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT Sricharan R
2023-03-30 4:32 ` Jakub Kicinski [this message]
2023-03-30 9:58 ` Sricharan Ramabadhran
2023-03-30 6:24 ` Manivannan Sadhasivam
2023-03-30 9:48 ` Sricharan Ramabadhran
2023-03-30 12:39 ` Manivannan Sadhasivam
2023-03-30 19:43 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329213216.7b0447e9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_srichara@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).