From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Shannon Nelson <shannon.nelson@amd.com>,
brett.creeley@amd.com, davem@davemloft.net,
netdev@vger.kernel.org, drivers@pensando.io, jiri@resnulli.us
Subject: Re: [PATCH v6 net-next 01/14] pds_core: initial framework for pds_core PF driver
Date: Thu, 30 Mar 2023 10:02:37 +0300 [thread overview]
Message-ID: <20230330070237.GQ831478@unreal> (raw)
In-Reply-To: <20230329192733.7473953c@kernel.org>
On Wed, Mar 29, 2023 at 07:27:33PM -0700, Jakub Kicinski wrote:
> On Wed, 29 Mar 2023 13:53:23 -0700 Shannon Nelson wrote:
> > The devlink alloc and registration are obviously a part of the probe and
> > thus device control setup, so I’m not sure why this is an issue.
> >
> > As is suggested in coding style, the smaller functions make for easier
> > reading, and keeps the related locking in a nice little package. Having
> > the devlink registration code gathered in one place in the devlink.c
> > file seems to follow most conventions, which then allows the helper
> > functions to be static to that file. This seems to be what about half
> > the drivers that use devlink have chosen to do.
>
> It is precisely the painful experience of dealing with those drivers
> when refactoring devlink code which makes me ask you to do it right.
It will be great if such pushback would be expressed for all types of obfuscations
and not devlink only.
Thanks
next prev parent reply other threads:[~2023-03-30 7:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 19:02 [PATCH v6 net-next 00/14] pds_core driver Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 01/14] pds_core: initial framework for pds_core PF driver Shannon Nelson
2023-03-25 23:39 ` Jakub Kicinski
2023-03-26 4:07 ` Shannon Nelson
2023-03-28 0:43 ` Jakub Kicinski
2023-03-28 6:19 ` Shannon Nelson
2023-03-28 22:17 ` Jakub Kicinski
2023-03-29 20:53 ` Shannon Nelson
2023-03-30 2:27 ` Jakub Kicinski
2023-03-30 7:02 ` Leon Romanovsky [this message]
2023-03-30 7:43 ` Shannon Nelson
2023-03-30 16:46 ` Jakub Kicinski
2023-03-24 19:02 ` [PATCH v6 net-next 02/14] pds_core: add devcmd device interfaces Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 03/14] pds_core: health timer and workqueue Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 04/14] pds_core: add devlink health facilities Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 05/14] pds_core: set up device and adminq Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 06/14] pds_core: Add adminq processing and commands Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 07/14] pds_core: add FW update feature to devlink Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 08/14] pds_core: set up the VIF definitions and defaults Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 09/14] pds_core: add initial VF device handling Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 10/14] pds_core: add auxiliary_bus devices Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 11/14] pds_core: devlink params for enabling VIF support Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 12/14] pds_core: add the aux client API Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 13/14] pds_core: publish events to the clients Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 14/14] pds_core: Kconfig and pds_core.rst Shannon Nelson
2023-03-25 20:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330070237.GQ831478@unreal \
--to=leon@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).