Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: kuba@kernel.org, andrew@lunn.ch, netdev@vger.kernel.org,
	steffen@innosonix.de, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Enable IGMP snooping on user ports only
Date: Thu, 30 Mar 2023 15:08:19 +0300	[thread overview]
Message-ID: <20230330120819.yfyzdiixqef657di@skbuf> (raw)
In-Reply-To: <20230329150140.701559-1-festevam@gmail.com>

On Wed, Mar 29, 2023 at 12:01:40PM -0300, Fabio Estevam wrote:
> From: Steffen Bätz <steffen@innosonix.de>
> 
> Do not set the MV88E6XXX_PORT_CTL0_IGMP_MLD_SNOOP bit on CPU or DSA ports.
> 
> This allows the host CPU port to be a regular IGMP listener by sending out
> IGMP Membership Reports, which would otherwise not be forwarded by the
> mv88exxx chip, but directly looped back to the CPU port itself.
> 
> Fixes: 54d792f257c6 ("net: dsa: Centralise global and port setup code into mv88e6xxx.")

I checked to see if the Fixes tag is correct, and... it's complicated.
That patch comes from the consolidation of multiple drivers
(mv88e6123_61_65.c, mv88e6131.c, mv88e6171.c, mv88e6352.c into what
later became the common mv88e6xxx driver. In principle, each of the
above drivers had their own buggy pre-existing logic to enable IGMP/MLD
snooping on all ports, but it seems a pointless exercise to add
individual Fixes: tags for all drivers prior to an unification process
that took place in 2015. So this gets my:

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

  parent reply	other threads:[~2023-03-30 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 15:01 [PATCH net] net: dsa: mv88e6xxx: Enable IGMP snooping on user ports only Fabio Estevam
2023-03-29 15:12 ` Andrew Lunn
2023-03-30 12:08 ` Vladimir Oltean [this message]
2023-03-30 12:52 ` Florian Fainelli
2023-03-30 18:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330120819.yfyzdiixqef657di@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen@innosonix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox