netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block refcounting logic
Date: Thu, 30 Mar 2023 15:13:49 +0300	[thread overview]
Message-ID: <20230330121349.GV831478@unreal> (raw)
In-Reply-To: <20230330120840.52079-1-nbd@nbd.name>

On Thu, Mar 30, 2023 at 02:08:38PM +0200, Felix Fietkau wrote:
> Since we call flow_block_cb_decref on FLOW_BLOCK_UNBIND, we also need to
> call flow_block_cb_incref for a newly allocated cb.
> Also fix the accidentally inverted refcount check on unbind.
> 
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

So what was changed between version 1 and 2?
It is expected to send cover letter too for series with more than 2 patches.

Thanks

  parent reply	other threads:[~2023-03-30 12:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 12:08 [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block refcounting logic Felix Fietkau
2023-03-30 12:08 ` [PATCH net v2 2/3] net: ethernet: mtk_eth_soc: fix L2 offloading with DSA untag offload Felix Fietkau
2023-03-30 18:38   ` Leon Romanovsky
2023-03-30 12:08 ` [PATCH net v2 3/3] net: ethernet: mtk_eth_soc: add missing ppe cache flush when deleting a flow Felix Fietkau
2023-03-30 18:38   ` Leon Romanovsky
2023-03-30 12:13 ` Leon Romanovsky [this message]
2023-03-30 12:22   ` [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block refcounting logic Felix Fietkau
2023-03-30 18:38 ` Leon Romanovsky
2023-03-30 18:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330121349.GV831478@unreal \
    --to=leon@kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).