From: Vladimir Oltean <olteanv@gmail.com>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: rzn1-a5psw: disable learning for standalone ports
Date: Thu, 30 Mar 2023 18:20:08 +0300 [thread overview]
Message-ID: <20230330152008.ji5mrwbpzklylpck@skbuf> (raw)
In-Reply-To: <20230330083408.63136-3-clement.leger@bootlin.com>
On Thu, Mar 30, 2023 at 10:34:08AM +0200, Clément Léger wrote:
> When port are in standalone mode, they should have learning disabled to
> avoid adding new entries in the MAC lookup table which might be used by
> other bridge ports to forward packets. While adding that, also make sure
> learning is enabled for CPU port.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
Usually I prefer this kind of change to be treated as a bug and
backported to older trees, because we see reports of setups which don't
work due to it. For example, see commit 15f7cfae912e ("net: dsa:
microchip: make learning configurable and keep it off while standalone")
which has a Fixes: tag.
prev parent reply other threads:[~2023-03-30 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:34 [PATCH net-next 0/2] net: dsa: rzn1-a5psw: disabled learning for standalone ports and fix STP support Clément Léger
2023-03-30 8:34 ` [PATCH net-next 1/2] net: dsa: rzn1-a5psw: enable DPBU for CPU port and fix STP states Clément Léger
2023-03-30 8:48 ` Clément Léger
2023-03-30 14:56 ` Vladimir Oltean
2023-03-30 15:01 ` Clément Léger
2023-03-30 15:16 ` Vladimir Oltean
2023-03-30 15:44 ` Clément Léger
2023-03-30 16:51 ` Vladimir Oltean
2023-03-31 7:21 ` Clément Léger
2023-03-30 8:34 ` [PATCH net-next 2/2] net: dsa: rzn1-a5psw: disable learning for standalone ports Clément Léger
2023-03-30 15:20 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330152008.ji5mrwbpzklylpck@skbuf \
--to=olteanv@gmail.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).