netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	zbr@ioremap.net, brauner@kernel.org, johannes@sipsolutions.net,
	ecree.xilinx@gmail.com, leon@kernel.org, keescook@chromium.org,
	socketcan@hartkopp.net, petrm@nvidia.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 6/7] netlink: Add multicast group level permissions
Date: Thu, 30 Mar 2023 23:39:41 -0700	[thread overview]
Message-ID: <20230330233941.70c98715@kernel.org> (raw)
In-Reply-To: <20230329182543.1161480-7-anjali.k.kulkarni@oracle.com>

On Wed, 29 Mar 2023 11:25:42 -0700 Anjali Kulkarni wrote:
> A new field perm_groups is added in netlink_sock to store the protocol's
> multicast group access permissions. This is to allow for a more fine
> grained access control than just at the protocol level. These
> permissions can be supplied by the protocol via the netlink_kernel_cfg.
> A new function netlink_multicast_allowed() is added, which checks if
> the protocol's multicast group has non-root access before allowing bind.

Is there a reason this is better than implementing .bind
in the connector family and filtering there?

  reply	other threads:[~2023-03-31  6:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 18:25 [PATCH v3 0/7] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 1/7] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 2/7] netlink: Add new netlink_release function Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 3/7] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 4/7] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 5/7] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 6/7] netlink: Add multicast group level permissions Anjali Kulkarni
2023-03-31  6:39   ` Jakub Kicinski [this message]
2023-03-31 17:00     ` Anjali Kulkarni
2023-03-31 17:24       ` Jakub Kicinski
2023-03-31 17:48         ` Anjali Kulkarni
2023-03-31 18:13           ` Jakub Kicinski
2023-03-31 18:38             ` Anjali Kulkarni
2023-03-29 18:25 ` [PATCH v3 7/7] connector/cn_proc: Allow non-root users access Anjali Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330233941.70c98715@kernel.org \
    --to=kuba@kernel.org \
    --cc=anjali.k.kulkarni@oracle.com \
    --cc=brauner@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=keescook@chromium.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=socketcan@hartkopp.net \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).