From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD8AC76196 for ; Fri, 31 Mar 2023 17:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231565AbjCaRY6 (ORCPT ); Fri, 31 Mar 2023 13:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbjCaRY6 (ORCPT ); Fri, 31 Mar 2023 13:24:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3710B1D2D1; Fri, 31 Mar 2023 10:24:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6F6962A92; Fri, 31 Mar 2023 17:24:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A29DC433EF; Fri, 31 Mar 2023 17:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680283496; bh=DxkTNqKM5xbHWQljDAPO6QEfNmH+hRrp/m3R6vfZIhk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s5x+xahQHmZqg2hvtfQBX/wg1q4FZgNhycQd8uwdaqur40s5cY0rnWWaHp0NCKQae yVpaw3UVI9/fNAcnigNDKupjuueOy85Xh9aNsyyJpVWFgq43hEUIQsx9PS9ZJko4yX 5Cft7U/xScnEbrlv90fLD0kvEm3o5fgltfXKyA4sH0Ieft5FtIcN14HoSJEUQK+WqC 6F+pI8siSO0kVb+lBDa9y01ZqHUXz5PYZbo/fBb/0/gH2epS6jwUj6jZBkapiggg3m 45tsfGsu30YsCvn5qL4uEmnWxI8SYPJCdNOb3gswKy5FOQNIChiYFukH9kGwSy0O08 YzIn76E6S0qNw== Date: Fri, 31 Mar 2023 10:24:54 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "zbr@ioremap.net" , "brauner@kernel.org" , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v3 6/7] netlink: Add multicast group level permissions Message-ID: <20230331102454.1251a97f@kernel.org> In-Reply-To: <830EC978-8B94-42D6-B70F-782724CEC82D@oracle.com> References: <20230329182543.1161480-1-anjali.k.kulkarni@oracle.com> <20230329182543.1161480-7-anjali.k.kulkarni@oracle.com> <20230330233941.70c98715@kernel.org> <830EC978-8B94-42D6-B70F-782724CEC82D@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 31 Mar 2023 17:00:27 +0000 Anjali Kulkarni wrote: > > Is there a reason this is better than implementing .bind > > in the connector family and filtering there? > > Are you suggesting adding something like a new struct proto_ops for > the connector family? I have not looked into that, though that would > seem like a lot of work, and also I have not seen any infra structure > to call into protocol specific bind from netlink bind? Where you're adding a release callback in patch 2 - there's a bind callback already three lines above. What am I missing?