From: Jakub Kicinski <kuba@kernel.org>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: fix up RX flow hash indirection table when setting channels
Date: Fri, 31 Mar 2023 21:46:16 -0700 [thread overview]
Message-ID: <20230331214616.228c458d@kernel.org> (raw)
In-Reply-To: <20230331092347.268996-1-vinschen@redhat.com>
On Fri, 31 Mar 2023 11:23:47 +0200 Corinna Vinschen wrote:
> priv->plat->rx_queues_to_use = rx_cnt;
> priv->plat->tx_queues_to_use = tx_cnt;
> + for (i = 0; i < ARRAY_SIZE(priv->rss.table); i++)
> + priv->rss.table[i] = ethtool_rxfh_indir_default(i, rx_cnt);
You need to check if (!netif_is_rxfh_configured())
if user set the config to not RSS to all queues we shouldn't reset.
next prev parent reply other threads:[~2023-04-01 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:23 [PATCH net] net: stmmac: fix up RX flow hash indirection table when setting channels Corinna Vinschen
2023-04-01 4:46 ` Jakub Kicinski [this message]
2023-04-03 12:11 ` [PATCH v2 " Corinna Vinschen
2023-04-04 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331214616.228c458d@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).