From: Jakub Kicinski <kuba@kernel.org>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: publish actual MTU restriction
Date: Fri, 31 Mar 2023 21:52:08 -0700 [thread overview]
Message-ID: <20230331215208.66d867ff@kernel.org> (raw)
In-Reply-To: <20230331092344.268981-1-vinschen@redhat.com>
On Fri, 31 Mar 2023 11:23:44 +0200 Corinna Vinschen wrote:
> Fixes: 2618abb73c895 ("stmmac: Fix kernel crashes for jumbo frames")
> Fixes: a2cd64f30140c ("net: stmmac: fix maxmtu assignment to be within valid range")
> Fixes: ebecb860ed228 ("net: stmmac: pci: Add HAPS support using GMAC5")
> Fixes: 58da0cfa6cf12 ("net: stmmac: create dwmac-intel.c to contain all Intel platform")
> Fixes: 30bba69d7db40 ("stmmac: pci: Add dwmac support for Loongson")
I'm not sure if we need fixes tags for this.
Are any users depending on the advertised values being exactly right?
> + /* stmmac_change_mtu restricts MTU to queue size.
> + * Set maxmtu accordingly, if it hasn't been set from DT.
> + */
> + if (priv->plat->maxmtu == 0) {
> + priv->plat->maxmtu = priv->plat->tx_fifo_size ?:
> + priv->dma_cap.tx_fifo_size;
> + priv->plat->maxmtu /= priv->plat->tx_queues_to_use;
tx_queues_to_use may change due to reconfiguration, no?
What will happen then?
next prev parent reply other threads:[~2023-04-01 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:23 [PATCH net-next] net: stmmac: publish actual MTU restriction Corinna Vinschen
2023-04-01 4:52 ` Jakub Kicinski [this message]
2023-04-03 9:12 ` Corinna Vinschen
2023-04-03 16:30 ` Jakub Kicinski
2023-04-03 18:17 ` Corinna Vinschen
2023-04-03 18:26 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331215208.66d867ff@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).