From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <brett.creeley@amd.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <drivers@pensando.io>,
<leon@kernel.org>, <jiri@resnulli.us>
Subject: Re: [PATCH v8 net-next 05/14] pds_core: set up device and adminq
Date: Fri, 31 Mar 2023 22:07:19 -0700 [thread overview]
Message-ID: <20230331220719.60bb08f3@kernel.org> (raw)
In-Reply-To: <20230330234628.14627-6-shannon.nelson@amd.com>
On Thu, 30 Mar 2023 16:46:19 -0700 Shannon Nelson wrote:
> + listlen = fw_list.num_fw_slots;
> + for (i = 0; i < listlen; i++) {
> + snprintf(buf, sizeof(buf), "fw.%s",
> + fw_list.fw_names[i].slotname);
> + err = devlink_info_version_stored_put(req, buf,
> + fw_list.fw_names[i].fw_version);
> + }
Keys must be enumerated in the kernel, no copying directly from
the FW please.
Also it'd be a little easier to review if the documentation was part
of the same patch as code :(
next prev parent reply other threads:[~2023-04-01 5:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 23:46 [PATCH v8 net-next 00/14] pds_core driver Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 01/14] pds_core: initial framework for pds_core PF driver Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 02/14] pds_core: add devcmd device interfaces Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 03/14] pds_core: health timer and workqueue Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 04/14] pds_core: add devlink health facilities Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 05/14] pds_core: set up device and adminq Shannon Nelson
2023-04-01 5:07 ` Jakub Kicinski [this message]
2023-04-01 19:48 ` Shannon Nelson
2023-04-03 20:37 ` Jakub Kicinski
2023-03-30 23:46 ` [PATCH v8 net-next 06/14] pds_core: Add adminq processing and commands Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 07/14] pds_core: add FW update feature to devlink Shannon Nelson
2023-04-01 5:09 ` Jakub Kicinski
2023-04-01 19:49 ` Shannon Nelson
2023-04-04 14:48 ` Jakub Kicinski
2023-03-30 23:46 ` [PATCH v8 net-next 08/14] pds_core: set up the VIF definitions and defaults Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 09/14] pds_core: add initial VF device handling Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 10/14] pds_core: add auxiliary_bus devices Shannon Nelson
2023-04-01 18:27 ` Leon Romanovsky
2023-04-01 20:15 ` Shannon Nelson
2023-04-03 6:18 ` Leon Romanovsky
2023-04-04 21:44 ` Shannon Nelson
2023-04-05 6:07 ` Leon Romanovsky
2023-04-05 17:17 ` Shannon Nelson
2023-04-14 12:37 ` Jason Gunthorpe
2023-03-30 23:46 ` [PATCH v8 net-next 11/14] pds_core: devlink params for enabling VIF support Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 12/14] pds_core: add the aux client API Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 13/14] pds_core: publish events to the clients Shannon Nelson
2023-03-30 23:46 ` [PATCH v8 net-next 14/14] pds_core: Kconfig and pds_core.rst Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331220719.60bb08f3@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).