From: Leon Romanovsky <leon@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: netdev@vger.kernel.org, Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: fix ppe flow accounting for L2 flows
Date: Mon, 3 Apr 2023 15:53:58 +0300 [thread overview]
Message-ID: <20230403125358.GC176342@unreal> (raw)
In-Reply-To: <20230331082945.75075-2-nbd@nbd.name>
On Fri, Mar 31, 2023 at 10:29:44AM +0200, Felix Fietkau wrote:
> For L2 flows, the packet/byte counters should report the sum of the
> counters of their subflows, both current and expired.
> In order to make this work, change the way that accounting data is tracked.
> Reset counters when a flow enters bind. Once it expires (or enters unbind),
> store the last counter value in struct mtk_flow_entry.
>
> Fixes: 3fbe4d8c0e53 ("net: ethernet: mtk_eth_soc: ppe: add support for flow accounting")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> drivers/net/ethernet/mediatek/mtk_ppe.c | 137 ++++++++++--------
> drivers/net/ethernet/mediatek/mtk_ppe.h | 8 +-
> .../net/ethernet/mediatek/mtk_ppe_debugfs.c | 2 +-
> .../net/ethernet/mediatek/mtk_ppe_offload.c | 17 +--
> 4 files changed, 88 insertions(+), 76 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-04-03 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 8:29 [PATCH net-next 1/3] net: ethernet: mtk_eth_soc: improve keeping track of offloaded flows Felix Fietkau
2023-03-31 8:29 ` [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: fix ppe flow accounting for L2 flows Felix Fietkau
2023-04-03 12:53 ` Leon Romanovsky [this message]
2023-03-31 8:29 ` [PATCH net-next 3/3] net: ethernet: mtk_eth_soc: fix ppe flow accounting for v1 hardware Felix Fietkau
2023-04-03 12:53 ` Leon Romanovsky
2023-04-03 12:53 ` [PATCH net-next 1/3] net: ethernet: mtk_eth_soc: improve keeping track of offloaded flows Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403125358.GC176342@unreal \
--to=leon@kernel.org \
--cc=daniel@makrotopia.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).