From: kernel test robot <lkp@intel.com>
To: Dmitry Safonov <dima@arista.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
Dmitry Safonov <dima@arista.com>,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
Salam Noureddine <noureddine@arista.com>
Subject: Re: [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk
Date: Tue, 4 Apr 2023 10:00:21 +0800 [thread overview]
Message-ID: <202304040904.0iYIgRHd-lkp@intel.com> (raw)
In-Reply-To: <20230403213420.1576559-10-dima@arista.com>
Hi Dmitry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7e364e56293bb98cae1b55fd835f5991c4e96e7d]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
base: 7e364e56293bb98cae1b55fd835f5991c4e96e7d
patch link: https://lore.kernel.org/r/20230403213420.1576559-10-dima%40arista.com
patch subject: [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230404/202304040904.0iYIgRHd-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6dd2eb18d51db7f4e1bfac2de38f7a5c2363ef0e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
git checkout 6dd2eb18d51db7f4e1bfac2de38f7a5c2363ef0e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/ipv6/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304040904.0iYIgRHd-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_timewait_ack':
>> net/ipv6/tcp_ipv6.c:1214:36: warning: variable 'rnext_key' set but not used [-Wunused-but-set-variable]
1214 | struct tcp_ao_key *rnext_key;
| ^~~~~~~~~
vim +/rnext_key +1214 net/ipv6/tcp_ipv6.c
1190
1191 static void tcp_v6_timewait_ack(struct sock *sk, struct sk_buff *skb)
1192 {
1193 struct inet_timewait_sock *tw = inet_twsk(sk);
1194 struct tcp_timewait_sock *tcptw = tcp_twsk(sk);
1195 struct tcp_ao_key *ao_key = NULL;
1196 u8 *traffic_key = NULL;
1197 u8 rcv_next = 0;
1198 u32 ao_sne = 0;
1199 #ifdef CONFIG_TCP_AO
1200 struct tcp_ao_info *ao_info;
1201
1202 /* FIXME: the segment to-be-acked is not verified yet */
1203 ao_info = rcu_dereference(tcptw->ao_info);
1204 if (ao_info) {
1205 const struct tcp_ao_hdr *aoh;
1206
1207 /* Invalid TCP option size or twice included auth */
1208 if (tcp_parse_auth_options(tcp_hdr(skb), NULL, &aoh))
1209 goto out;
1210 if (aoh)
1211 ao_key = tcp_ao_established_key(ao_info, aoh->rnext_keyid, -1);
1212 }
1213 if (ao_key) {
> 1214 struct tcp_ao_key *rnext_key;
1215
1216 traffic_key = snd_other_key(ao_key);
1217 /* rcv_next switches to our rcv_next */
1218 rnext_key = READ_ONCE(ao_info->rnext_key);
1219 rcv_next = ao_info->rnext_key->rcvid;
1220 ao_sne = tcp_ao_compute_sne(ao_info->snd_sne,
1221 ao_info->snd_sne_seq,
1222 tcptw->tw_snd_nxt);
1223 }
1224 #endif
1225
1226 tcp_v6_send_ack(sk, skb, tcptw->tw_snd_nxt, tcptw->tw_rcv_nxt,
1227 tcptw->tw_rcv_wnd >> tw->tw_rcv_wscale,
1228 tcp_time_stamp_raw() + tcptw->tw_ts_offset,
1229 tcptw->tw_ts_recent, tw->tw_bound_dev_if, tcp_twsk_md5_key(tcptw),
1230 tw->tw_tclass, cpu_to_be32(tw->tw_flowlabel), tw->tw_priority,
1231 tw->tw_txhash, ao_key, traffic_key, rcv_next, ao_sne);
1232
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-04-04 2:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 21:33 [PATCH v5 00/21] net/tcp: Add TCP-AO support Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-04-04 2:10 ` kernel test robot
2023-04-04 2:21 ` kernel test robot
2023-04-04 3:44 ` kernel test robot
2023-04-03 21:34 ` [PATCH v5 02/21] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 03/21] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 04/21] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 05/21] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 06/21] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 07/21] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 08/21] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-04-04 2:00 ` kernel test robot [this message]
2023-04-03 21:34 ` [PATCH v5 10/21] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 11/21] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 12/21] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 13/21] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 14/21] net/tcp: Add TCP-AO SNE support Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 15/21] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 16/21] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 17/21] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 18/21] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 19/21] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 20/21] net/tcp-ao: Add static_key for TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 21/21] net/tcp-ao: Wire up l3index to TCP-AO Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304040904.0iYIgRHd-lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).