Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

["Köry Maincent" <kory.maincent@bootlin.com>]

On Mon, 3 Apr 2023 18:18:18 +0100
Vadim Fedorenko <vadim.fedorenko@linux.dev> wrote:

> On 03/04/2023 16:42, Max Georgiev wrote:
> > On Mon, Apr 3, 2023 at 6:26 AM Vladimir Oltean <vladimir.oltean@nxp.com>
> > wrote:  
> >>
> >> On Sun, Apr 02, 2023 at 08:24:35AM -0600, Maxim Georgiev wrote:  
> >>> Current NIC driver API demands drivers supporting hardware timestamping
> >>> to support SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs. Handling these IOCTLs
> >>> requires dirivers to implement request parameter structure translation
> >>> between user and kernel address spaces, handling possible
> >>> translation failures, etc. This translation code is pretty much
> >>> identical across most of the NIC drivers that support SIOCGHWTSTAMP/
> >>> SIOCSHWTSTAMP.
> >>> This patch extends NDO functiuon set with ndo_hwtstamp_get/set
> >>> functions, implements SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTL translation
> >>> to ndo_hwtstamp_get/set function calls including parameter structure
> >>> translation and translation error handling.
> >>>
> >>> This patch is sent out as RFC.
> >>> It still pending on basic testing.  
> >>
> >> Who should do that testing? Do you have any NIC with the hardware
> >> timestamping capability?  
> > 
> > I'm planning to do the testing with netdevsim. I don't have access to
> > any NICs with
> > hardware timestamping support.
> >   
> 
> Hi Max!
> I might do some manual tests with the hardware that support timestamping 
> once you respin the series with the changes discussed in the code 
> comments. I'll convert hardware drivers myself to support new NDO on top 
> of your patches.

Same here.

Köry,