From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1725FC76196 for ; Tue, 4 Apr 2023 03:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232690AbjDDDpI (ORCPT ); Mon, 3 Apr 2023 23:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjDDDpG (ORCPT ); Mon, 3 Apr 2023 23:45:06 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3222B1BFA; Mon, 3 Apr 2023 20:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680579905; x=1712115905; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rjKUMdET1Lz0JUqv3scJy4WtrTrQUy5A98bRZCl/9QI=; b=F8dUrvVOY+/acocUOC1ZORQphHweVX5iIm6BZM7JxOcEGgormMMBFefS 9BfZkglwjwV4faRAn52jCLjva288AE/Vg2scCxN7WDNCEBOVZY7A40Bwb hNOISmKdaqxySPqBhS12x4sMFZ4y3KzqjKucDbuCbYcz98fhUf6Qf3+Jw mIvWCZuVl1bPZ+INevJtMmWG/JlbKTgr8syVc8J4tG6fA6N0HZBBULg0C RkkZxtLLHLPuFk7ktLOKIRGzv/f6gfBOv5zRzES3Q9DeOuSijwoqzOWXz uqFty+y62FKSKWKhX6ff9hTlk+1k17rZXYFvXxk8kEXDvdUGnaAj53xal w==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="369892062" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="369892062" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 20:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="829821892" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="829821892" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 03 Apr 2023 20:44:59 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pjXbO-000P8K-2e; Tue, 04 Apr 2023 03:44:58 +0000 Date: Tue, 4 Apr 2023 11:44:17 +0800 From: kernel test robot To: Dmitry Safonov , linux-kernel@vger.kernel.org, David Ahern , Eric Dumazet , Paolo Abeni , Jakub Kicinski , "David S. Miller" Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, Dmitry Safonov , Andy Lutomirski , Ard Biesheuvel , Bob Gilligan , Dan Carpenter , David Laight , Eric Biggers , "Eric W. Biederman" , Francesco Ruggeri , Herbert Xu , Hideaki YOSHIFUJI , Ivan Delalande , Leonard Crestez , Salam Noureddine Subject: Re: [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Message-ID: <202304041119.egH8ZcDT-lkp@intel.com> References: <20230403213420.1576559-2-dima@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403213420.1576559-2-dima@arista.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Dmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on 7e364e56293bb98cae1b55fd835f5991c4e96e7d] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020 base: 7e364e56293bb98cae1b55fd835f5991c4e96e7d patch link: https://lore.kernel.org/r/20230403213420.1576559-2-dima%40arista.com patch subject: [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO config: i386-randconfig-s001-20230403 (https://download.01.org/0day-ci/archive/20230404/202304041119.egH8ZcDT-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/94408bb4cf5cbcc772ab4d70eeb73bda183c6124 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020 git checkout 94408bb4cf5cbcc772ab4d70eeb73bda183c6124 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 olddefconfig make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash net/ipv4/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304041119.egH8ZcDT-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> net/ipv4/tcp_sigpool.c:63:16: sparse: sparse: incompatible types in comparison expression (different type sizes): >> net/ipv4/tcp_sigpool.c:63:16: sparse: unsigned int * >> net/ipv4/tcp_sigpool.c:63:16: sparse: unsigned long * net/ipv4/tcp_sigpool.c:297:5: sparse: sparse: context imbalance in 'tcp_sigpool_start' - different lock contexts for basic block vim +63 net/ipv4/tcp_sigpool.c 43 44 /* 45 * sigpool_reserve_scratch - re-allocates scratch buffer, slow-path 46 * @size: request size for the scratch/temp buffer 47 */ 48 static int sigpool_reserve_scratch(size_t size) 49 { 50 struct scratches_to_free *stf; 51 size_t stf_sz = struct_size(stf, scratches, num_possible_cpus()); 52 int cpu, err = 0; 53 54 lockdep_assert_held(&cpool_mutex); 55 if (__scratch_size >= size) 56 return 0; 57 58 stf = kmalloc(stf_sz, GFP_KERNEL); 59 if (!stf) 60 return -ENOMEM; 61 stf->cnt = 0; 62 > 63 size = max(size, __scratch_size); 64 cpus_read_lock(); 65 for_each_possible_cpu(cpu) { 66 void *scratch, *old_scratch; 67 68 scratch = kmalloc_node(size, GFP_KERNEL, cpu_to_node(cpu)); 69 if (!scratch) { 70 err = -ENOMEM; 71 break; 72 } 73 74 old_scratch = rcu_replace_pointer(per_cpu(sigpool_scratch, cpu), scratch, lockdep_is_held(&cpool_mutex)); 75 if (!cpu_online(cpu) || !old_scratch) { 76 kfree(old_scratch); 77 continue; 78 } 79 stf->scratches[stf->cnt++] = old_scratch; 80 } 81 cpus_read_unlock(); 82 if (!err) 83 __scratch_size = size; 84 85 call_rcu(&stf->rcu, free_old_scratches); 86 return err; 87 } 88 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests