From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Maxim Georgiev <glipus@gmail.com>
Cc: kory.maincent@bootlin.com, kuba@kernel.org,
netdev@vger.kernel.org, maxime.chevallier@bootlin.com,
vadim.fedorenko@linux.dev, richardcochran@gmail.com,
gerhard@engleder-embedded.com
Subject: Re: [RFC PATCH v3 4/5] Convert netdevsim driver to use ndo_hwtstamp_get/set for hw timestamp requests
Date: Wed, 5 Apr 2023 15:18:48 +0300 [thread overview]
Message-ID: <20230405121848.yojvkbms4cvfriec@skbuf> (raw)
In-Reply-To: <20230405063330.36287-1-glipus@gmail.com>
On Wed, Apr 05, 2023 at 12:33:30AM -0600, Maxim Georgiev wrote:
> Changing netdevsim driver to use the newly introduced ndo_hwtstamp_get/set
> callback functions instead of implementing full-blown SIOCGHWTSTAMP/
> SIOCSHWTSTAMP IOCTLs handling logic.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Maxim Georgiev <glipus@gmail.com>
> ---
The commit message describes a conversion, but this isn't a conversion,
it's new functionality (which to my eyes is also incomplete).
Also, what happened to:
| I'd vote to split netdevsim out, and it needs a selftest which
| exercises it under tools/testing/selftests/drivers/net/netdevsim/
| to get merged...
https://lore.kernel.org/netdev/20230403141918.3257a195@kernel.org/
next prev parent reply other threads:[~2023-04-05 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 6:33 [RFC PATCH v3 4/5] Convert netdevsim driver to use ndo_hwtstamp_get/set for hw timestamp requests Maxim Georgiev
2023-04-05 12:18 ` Vladimir Oltean [this message]
2023-04-05 16:35 ` Max Georgiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405121848.yojvkbms4cvfriec@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=gerhard@engleder-embedded.com \
--cc=glipus@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox