From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net 1/2] iavf: refactor VLAN filter states
Date: Wed, 5 Apr 2023 17:59:08 -0700 [thread overview]
Message-ID: <20230405175908.2d3b504f@kernel.org> (raw)
In-Reply-To: <99053387-16ff-9ed0-ef12-7bcbc7a7af2e@intel.com>
On Wed, 5 Apr 2023 18:50:55 -0600 Ahmed Zaki wrote:
> On 2023-04-05 18:15, Jakub Kicinski wrote:
> > On Tue, 4 Apr 2023 10:25:21 -0700 Tony Nguyen wrote:
> >> + __IAVF_VLAN_INVALID,
> >> + __IAVF_VLAN_ADD, /* filter needs to be added */
> >> + __IAVF_VLAN_IS_NEW, /* filter is new, wait for PF answer */
> >> + __IAVF_VLAN_ACTIVE, /* filter is accepted by PF */
> >> + __IAVF_VLAN_REMOVE, /* filter needs to be removed */
> > Why the leading underscores?
>
> Just following the convention. iavf_tc_state_t and
> iavf_cloud_filter_state_t have these underscores. Same for iavf_state_t.
What is the convention, tho? Differently put what is the thing
that would be defined with the same names but without the underscores?
My intuition is that we prefix bit numbers with __,
then the mask (1 << __BIT_NO) does not have a prefix.
But these are not used as bits anywhere, in fact you're going away
from bits...
next prev parent reply other threads:[~2023-04-06 0:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:25 [PATCH net 0/2][pull request] iavf: fix racing in VLANs Tony Nguyen
2023-04-04 17:25 ` [PATCH net 1/2] iavf: refactor VLAN filter states Tony Nguyen
2023-04-06 0:15 ` Jakub Kicinski
2023-04-06 0:50 ` Ahmed Zaki
2023-04-06 0:59 ` Jakub Kicinski [this message]
2023-04-06 18:55 ` Ahmed Zaki
2023-04-06 20:04 ` Jakub Kicinski
2023-04-04 17:25 ` [PATCH net 2/2] iavf: remove active_cvlans and active_svlans bitmaps Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405175908.2d3b504f@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).