From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Ferenc Fejes <ferenc.fejes@ericsson.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roger Quadros <rogerq@kernel.org>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Harini Katakam <harini.katakam@amd.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org, Ferenc Fejes <fejes@inf.elte.hu>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH v4 net-next 6/9] net/sched: mqprio: allow per-TC user input of FP adminStatus
Date: Wed, 5 Apr 2023 18:12:34 -0700 [thread overview]
Message-ID: <20230405181234.35dbd2f9@kernel.org> (raw)
In-Reply-To: <20230403103440.2895683-7-vladimir.oltean@nxp.com>
On Mon, 3 Apr 2023 13:34:37 +0300 Vladimir Oltean wrote:
> +static int mqprio_parse_tc_entry(u32 fp[TC_QOPT_MAX_QUEUE],
> + struct nlattr *opt,
> + unsigned long *seen_tcs,
> + struct netlink_ext_ack *extack)
> +{
> + struct nlattr *tb[TCA_MQPRIO_TC_ENTRY_MAX + 1] = { };
nit: no need to clear it nla_parse*() zeros the memory
> + int err, tc;
> +
> + err = nla_parse_nested(tb, TCA_MQPRIO_TC_ENTRY_MAX, opt,
> + mqprio_tc_entry_policy, extack);
> + if (err < 0)
> + return err;
> +
> + if (!tb[TCA_MQPRIO_TC_ENTRY_INDEX]) {
> + NL_SET_ERR_MSG(extack, "TC entry index missing");
Are you not using NL_REQ_ATTR_CHECK() because iproute can't actually
parse the result? :(
> + return -EINVAL;
> + }
> +
> + tc = nla_get_u32(tb[TCA_MQPRIO_TC_ENTRY_INDEX]);
> + if (*seen_tcs & BIT(tc)) {
> + NL_SET_ERR_MSG(extack, "Duplicate tc entry");
set attr in extack?
minor heads up - I'll take the trivial cleanup patch from Pedro
so make sure you rebase:
https://lore.kernel.org/all/20230404203449.1627033-1-pctammela@mojatatu.com/
next prev parent reply other threads:[~2023-04-06 1:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:34 [PATCH v4 net-next 0/9] Add tc-mqprio and tc-taprio support for preemptible traffic classes Vladimir Oltean
2023-04-03 10:34 ` [PATCH v4 net-next 1/9] net: ethtool: create and export ethtool_dev_mm_supported() Vladimir Oltean
2023-04-03 10:34 ` [PATCH v4 net-next 2/9] net/sched: mqprio: simplify handling of nlattr portion of TCA_OPTIONS Vladimir Oltean
2023-04-07 16:05 ` Jamal Hadi Salim
2023-04-03 10:34 ` [PATCH v4 net-next 3/9] net/sched: mqprio: add extack to mqprio_parse_nlattr() Vladimir Oltean
2023-04-07 16:06 ` Jamal Hadi Salim
2023-04-03 10:34 ` [PATCH v4 net-next 4/9] net/sched: mqprio: add an extack message to mqprio_parse_opt() Vladimir Oltean
2023-04-07 16:08 ` Jamal Hadi Salim
2023-04-03 10:34 ` [PATCH v4 net-next 5/9] net/sched: pass netlink extack to mqprio and taprio offload Vladimir Oltean
2023-04-07 16:09 ` Jamal Hadi Salim
2023-04-03 10:34 ` [PATCH v4 net-next 6/9] net/sched: mqprio: allow per-TC user input of FP adminStatus Vladimir Oltean
2023-04-06 1:12 ` Jakub Kicinski [this message]
2023-04-11 17:01 ` Vladimir Oltean
2023-04-11 18:18 ` Jakub Kicinski
2023-04-07 16:22 ` Jamal Hadi Salim
2023-04-07 16:41 ` Vladimir Oltean
2023-04-07 18:49 ` Jamal Hadi Salim
2023-04-07 19:30 ` Vladimir Oltean
2023-04-07 21:40 ` Jamal Hadi Salim
2023-04-07 21:52 ` Vladimir Oltean
2023-04-08 1:01 ` Jakub Kicinski
2023-04-03 10:34 ` [PATCH v4 net-next 7/9] net/sched: taprio: " Vladimir Oltean
2023-04-07 16:27 ` Jamal Hadi Salim
2023-04-03 10:34 ` [PATCH v4 net-next 8/9] net: enetc: rename "mqprio" to "qopt" Vladimir Oltean
2023-04-03 10:34 ` [PATCH v4 net-next 9/9] net: enetc: add support for preemptible traffic classes Vladimir Oltean
2023-04-03 10:54 ` [PATCH v4 net-next 0/9] Add tc-mqprio and tc-taprio " Vladimir Oltean
2023-04-03 11:04 ` Vladimir Oltean
2023-04-03 21:32 ` Jakub Kicinski
2023-04-03 23:43 ` Vladimir Oltean
2023-04-04 0:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405181234.35dbd2f9@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fejes@inf.elte.hu \
--cc=ferenc.fejes@ericsson.com \
--cc=gerhard@engleder-embedded.com \
--cc=harini.katakam@amd.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=michael.wei.hong.sit@intel.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=pranavi.somisetty@amd.com \
--cc=rogerq@kernel.org \
--cc=simon.horman@corigine.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).