From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50905C7619A for ; Thu, 6 Apr 2023 01:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234461AbjDFBNj (ORCPT ); Wed, 5 Apr 2023 21:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234482AbjDFBNi (ORCPT ); Wed, 5 Apr 2023 21:13:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBA598699; Wed, 5 Apr 2023 18:13:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA1A162B08; Thu, 6 Apr 2023 01:12:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05FE9C433D2; Thu, 6 Apr 2023 01:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680743556; bh=dP8/jMHNzL9KeQJlhwq07VX3j1IKkLRUF9JRQAZlzw8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AihnE643wEKX8L/vYQsqAiX/gazUXOQ9EGr5jKrE9AVzL9OhaB0PDqiTlt0clJwPi 1T+spMWJPK6MlsIOa/ZmMHxwyge6QKva2ob0Sdo20aac2NZder2kqlVc0HzOHY/C0M ZtLS3ijpQ62YS7CYkdFPMP/W6jb8zzEW5Do+JkpurmRHc3G7kyLLlfqRh1q1VUQYze WG54zuaGOOWbD/Y4szLrAHAmYFEffg/C5IWMg+GFrgjkUTrX++w1N8YgHn6qHKY954 66fkn4rIWW+sW8PrgeGaXnd4ifaGbVQUVkciENwf0tnZGLWoUXawe0OldYM23gNXfa xvDEA0XmkFT6Q== Date: Wed, 5 Apr 2023 18:12:34 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Vinicius Costa Gomes , Kurt Kanzenbach , Gerhard Engleder , Amritha Nambiar , Ferenc Fejes , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , Giuseppe Cavallaro , Alexandre Torgue , Michael Sit Wei Hong , Mohammad Athari Bin Ismail , Oleksij Rempel , Jacob Keller , linux-kernel@vger.kernel.org, Ferenc Fejes , Simon Horman Subject: Re: [PATCH v4 net-next 6/9] net/sched: mqprio: allow per-TC user input of FP adminStatus Message-ID: <20230405181234.35dbd2f9@kernel.org> In-Reply-To: <20230403103440.2895683-7-vladimir.oltean@nxp.com> References: <20230403103440.2895683-1-vladimir.oltean@nxp.com> <20230403103440.2895683-7-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 3 Apr 2023 13:34:37 +0300 Vladimir Oltean wrote: > +static int mqprio_parse_tc_entry(u32 fp[TC_QOPT_MAX_QUEUE], > + struct nlattr *opt, > + unsigned long *seen_tcs, > + struct netlink_ext_ack *extack) > +{ > + struct nlattr *tb[TCA_MQPRIO_TC_ENTRY_MAX + 1] = { }; nit: no need to clear it nla_parse*() zeros the memory > + int err, tc; > + > + err = nla_parse_nested(tb, TCA_MQPRIO_TC_ENTRY_MAX, opt, > + mqprio_tc_entry_policy, extack); > + if (err < 0) > + return err; > + > + if (!tb[TCA_MQPRIO_TC_ENTRY_INDEX]) { > + NL_SET_ERR_MSG(extack, "TC entry index missing"); Are you not using NL_REQ_ATTR_CHECK() because iproute can't actually parse the result? :( > + return -EINVAL; > + } > + > + tc = nla_get_u32(tb[TCA_MQPRIO_TC_ENTRY_INDEX]); > + if (*seen_tcs & BIT(tc)) { > + NL_SET_ERR_MSG(extack, "Duplicate tc entry"); set attr in extack? minor heads up - I'll take the trivial cleanup patch from Pedro so make sure you rebase: https://lore.kernel.org/all/20230404203449.1627033-1-pctammela@mojatatu.com/