From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709B1C76196 for ; Thu, 6 Apr 2023 14:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238788AbjDFOZY (ORCPT ); Thu, 6 Apr 2023 10:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239108AbjDFOZI (ORCPT ); Thu, 6 Apr 2023 10:25:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967568684; Thu, 6 Apr 2023 07:25:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32CC062B89; Thu, 6 Apr 2023 14:25:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5763C433D2; Thu, 6 Apr 2023 14:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680791106; bh=dVLrRKMixxYJuJxgFVKfxaLTvhfPWlQjL3ZdegVqCYo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XrQ4vEbqAY8KxcnwjjJnmbT/Yk4YENoIhmdid/YAyH0cqbPKOsJU5RsEvdJBhtpFr YbH/Y4Ry6cRD7NFkUq/mcW6RCuy4+C9qSP4ScbpNd+HtXvYzFLWPfJFcIyJhPmXT0+ qZCj+qXajGDAhZtUKKL3BFDD7HzuenGi+I/0ROZzQuFXZezmr6MKE5E+DfL2huyXJk tI43BX9eOW8OFlSnz8RqNJlOsHKpr1rb6O3M5jmqTC0oUQu0grYQYm79hd/qkHgdVT JB0vPjHUIzCVKnU97MvxXPevOkTIPwtFVaf4O3oq3a7RLP34yAYvhgYc+JXZ2vmPIG fH6ktcgA64cMQ== Date: Thu, 6 Apr 2023 07:25:04 -0700 From: Jakub Kicinski To: Michael Sit Wei Hong Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, hkallweit1@gmail.com, andrew@lunn.ch, Martin Blumenstingl , Shahab Vahedi , Marek Szyprowski , Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann , Zulkifli Muhammad Husaini , Tan Tee Min , hock.leong.kweh@intel.com Subject: Re: [RESEND PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Message-ID: <20230406072504.68e032e6@kernel.org> In-Reply-To: <20230406024541.3556305-1-michael.wei.hong.sit@intel.com> References: <20230406024541.3556305-1-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 6 Apr 2023 10:45:41 +0800 Michael Sit Wei Hong wrote: > Some DT devices already have phy device configured in the DT/ACPI. > Current implementation scans for a phy unconditionally even though > there is a phy listed in the DT/ACPI and already attached. > > We should check the fwnode if there is any phy device listed in > fwnode and decide whether to scan for a phy to attach to. Why did you resend this?