From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub
Date: Thu, 6 Apr 2023 07:35:56 -0700 [thread overview]
Message-ID: <20230406073556.7d63df19@kernel.org> (raw)
In-Reply-To: <93ae54eb-5287-8d63-5109-973bfacc6b74@gmail.com>
On Thu, 6 Apr 2023 06:07:45 -0700 Florian Fainelli wrote:
> > There have been objections from Jakub Kicinski that using notifiers in
> > general when they are not absolutely necessary creates complications to
> > the control flow and difficulties to maintainers who look at the code.
> > So there is a desire to not use notifiers.
>
> Jakub is there a general desire to move away from notifiers? If so, do
> you have a list of things that may no longer belong there?
I think they are harder to follow when debugging, so if other options
are available we should prefer them. Built-in code calling modular code,
for example, can be done thru a function pointer, which is the case
here.
next prev parent reply other threads:[~2023-04-06 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 11:42 [PATCH v2 net-next] net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub Vladimir Oltean
2023-04-06 13:07 ` Florian Fainelli
2023-04-06 14:35 ` Jakub Kicinski [this message]
2023-04-09 14:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406073556.7d63df19@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).