From: Jakub Kicinski <kuba@kernel.org>
To: Liang Chen <liangchen.linux@gmail.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
hawk@kernel.org, davem@davemloft.net, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: Fix a race between coalescing and releasing SKBs
Date: Thu, 6 Apr 2023 07:59:08 -0700 [thread overview]
Message-ID: <20230406075908.5ebcb5a0@kernel.org> (raw)
In-Reply-To: <CAKhg4tK0D2CqbcCm5TW6LeoBuyQKq7ThrQTS7fLHBUXfoFe1XA@mail.gmail.com>
On Thu, 6 Apr 2023 19:54:23 +0800 Liang Chen wrote:
> > > Same feeling on my side.
> > > I prefer not trying to merge mixed pp_recycle skbs "just because we
> > > could" at the expense
> > > of adding more code in a fast path.
> >
> > +1 here. The intention of recycling was to affect the normal path as
> > less as possible. On top of that, we've some amount of race
> > conditions over the years, trying to squeeze more performance with
> > similar tricks. I'd much rather be safe here, since recycling by
> > itself is a great performance boost
>
> Sorry, I didn't check my inbox before sending out the v2 patch.
I can discard v2 from patchwork, let's continue the conversation
here.
> Yeah, It is a bit complicated as we expected. The patch is sent out.
> Please take a look to see if it is the way to go, or We should stay
> with the current patch for simplicity reasons. Thanks!
Sounds like you know what Eric and Ilias agreed with, I'm a bit
confused.. are we basically going back to v1? (hopefully with coding
style fixed)
next prev parent reply other threads:[~2023-04-06 14:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 7:47 [PATCH] skbuff: Fix a race between coalescing and releasing SKBs Liang Chen
2023-04-04 11:18 ` Yunsheng Lin
2023-04-04 15:51 ` Alexander H Duyck
2023-04-05 1:21 ` Jakub Kicinski
2023-04-05 8:18 ` Liang Chen
2023-04-05 14:50 ` Jakub Kicinski
2023-04-06 3:22 ` Liang Chen
2023-04-05 15:06 ` Alexander Duyck
2023-04-06 3:28 ` Liang Chen
2023-04-06 9:56 ` Eric Dumazet
2023-04-06 10:46 ` Ilias Apalodimas
2023-04-06 11:54 ` Liang Chen
2023-04-06 14:59 ` Jakub Kicinski [this message]
2023-04-07 0:45 ` Liang Chen
2023-04-11 0:26 ` Jakub Kicinski
2023-04-12 7:27 ` Liang Chen
2023-04-12 13:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406075908.5ebcb5a0@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=liangchen.linux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).