From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF38C761A6 for ; Thu, 6 Apr 2023 11:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238130AbjDFLe6 (ORCPT ); Thu, 6 Apr 2023 07:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238133AbjDFLeH (ORCPT ); Thu, 6 Apr 2023 07:34:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFBEC9740; Thu, 6 Apr 2023 04:33:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFAD66445E; Thu, 6 Apr 2023 11:33:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A870C4339B; Thu, 6 Apr 2023 11:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780789; bh=60KjthHM48i7AZz9pQMoSqw2N8MTW3cZYBNSr5AgoMU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YwacQiedOd0Or8G1UU1hOVODHn3DBmtTKrArjbuXnbcHry61lUyDKdoSZsxtbR0UP EjxNFwDT7mTxKRGx8uWgZ6bi0NUjLby1xLflGa5LpTMQAAo5V4U0WxuB/oV47Ufbe5 vlBNf9nSeFaU9QCD5QcRG+vmSL5YOZE0LhWZOTRLMaPcjWZLPKbYFXttqEEzHxFks3 z2V96zmTnfcF8FcXiscjrFS/Ng8yrhfr14UYM2uwZkScRhCdTci9ovP0CokGkZYGDx GgNLeQVuQYV0aRfPWdRNPpdVEuYfuTIlB1eL0EeZHmo5j3bvXvbyeHTf/05i/J07oS cwhfdXWsDVUxA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= , Florian Fainelli , "David S . Miller" , Sasha Levin , andrew@lunn.ch, olteanv@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 07/11] net: dsa: b53: mmap: add phy ops Date: Thu, 6 Apr 2023 07:32:46 -0400 Message-Id: <20230406113250.648634-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113250.648634-1-sashal@kernel.org> References: <20230406113250.648634-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Álvaro Fernández Rojas [ Upstream commit 45977e58ce65ed0459edc9a0466d9dfea09463f5 ] Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing B53_PORT_MII_PAGE registers which hangs the device. This access should be done through the MDIO Mux bus controller. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/b53/b53_mmap.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index 3388f620fac99..ca6f53c630676 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -216,6 +216,18 @@ static int b53_mmap_write64(struct b53_device *dev, u8 page, u8 reg, return 0; } +static int b53_mmap_phy_read16(struct b53_device *dev, int addr, int reg, + u16 *value) +{ + return -EIO; +} + +static int b53_mmap_phy_write16(struct b53_device *dev, int addr, int reg, + u16 value) +{ + return -EIO; +} + static const struct b53_io_ops b53_mmap_ops = { .read8 = b53_mmap_read8, .read16 = b53_mmap_read16, @@ -227,6 +239,8 @@ static const struct b53_io_ops b53_mmap_ops = { .write32 = b53_mmap_write32, .write48 = b53_mmap_write48, .write64 = b53_mmap_write64, + .phy_read16 = b53_mmap_phy_read16, + .phy_write16 = b53_mmap_phy_write16, }; static int b53_mmap_probe_of(struct platform_device *pdev, -- 2.39.2