From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B83C77B70 for ; Thu, 6 Apr 2023 11:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238412AbjDFLgl (ORCPT ); Thu, 6 Apr 2023 07:36:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238324AbjDFLfw (ORCPT ); Thu, 6 Apr 2023 07:35:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C7E1B47D; Thu, 6 Apr 2023 04:33:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 190926459D; Thu, 6 Apr 2023 11:33:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 498CEC4339E; Thu, 6 Apr 2023 11:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780835; bh=F//45VwgUYwqnq/zqqoCuZrjr2a4lXeB7zZZmi+WW18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lZHA75yig9bdhhT2jcSVqh53JwKheuk3qqpZMDWyeaSsN/R15s/qxLdAcsWEyXQwD Y7HfJuhPeEiZS5QlbZuopCK2yZx5TwPoRu8Nnb35ei4sImgZT1H8lOrxPcFgb41w7/ 9BR5aDDdf1tTRF6qsROsX6l45zqMRQMLa3ZVXxpSOJamMXM/TEFcGB6FwJdwBQ+eSC 76okOAlyvx9ONvO39neW8gxH5lvGuiUuUjuj//+RPATddYDiHkIiyP03kKsLHhsF+U 0cd6Cm873xdhCZgPhpdClbVV9LwePPsbC0926mZuwr5pZ8NyJV1fEETEMATHzcyCb0 AVTWlkEkElHLQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= , Florian Fainelli , "David S . Miller" , Sasha Levin , andrew@lunn.ch, olteanv@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 6/9] net: dsa: b53: mmap: add phy ops Date: Thu, 6 Apr 2023 07:33:34 -0400 Message-Id: <20230406113337.648916-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113337.648916-1-sashal@kernel.org> References: <20230406113337.648916-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Álvaro Fernández Rojas [ Upstream commit 45977e58ce65ed0459edc9a0466d9dfea09463f5 ] Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing B53_PORT_MII_PAGE registers which hangs the device. This access should be done through the MDIO Mux bus controller. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/b53/b53_mmap.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index c628d0980c0b1..1d52cb3e46d52 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -215,6 +215,18 @@ static int b53_mmap_write64(struct b53_device *dev, u8 page, u8 reg, return 0; } +static int b53_mmap_phy_read16(struct b53_device *dev, int addr, int reg, + u16 *value) +{ + return -EIO; +} + +static int b53_mmap_phy_write16(struct b53_device *dev, int addr, int reg, + u16 value) +{ + return -EIO; +} + static const struct b53_io_ops b53_mmap_ops = { .read8 = b53_mmap_read8, .read16 = b53_mmap_read16, @@ -226,6 +238,8 @@ static const struct b53_io_ops b53_mmap_ops = { .write32 = b53_mmap_write32, .write48 = b53_mmap_write48, .write64 = b53_mmap_write64, + .phy_read16 = b53_mmap_phy_read16, + .phy_write16 = b53_mmap_phy_write16, }; static int b53_mmap_probe(struct platform_device *pdev) -- 2.39.2