From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>,
"Rafal Romanowski" <rafal.romanowski@intel.com>
Subject: Re: [PATCH net 1/2] iavf: refactor VLAN filter states
Date: Thu, 6 Apr 2023 13:04:15 -0700 [thread overview]
Message-ID: <20230406130415.1aa1d1cd@kernel.org> (raw)
In-Reply-To: <e6e256a9-009b-593a-9f06-6f4adb4df688@intel.com>
On Thu, 6 Apr 2023 12:55:43 -0600 Ahmed Zaki wrote:
> > My intuition is that we prefix bit numbers with __,
> > then the mask (1 << __BIT_NO) does not have a prefix.
> >
> > But these are not used as bits anywhere, in fact you're going away
> > from bits...
>
> Ok, how about sending v2 without these underscores, then send another
> patch to net-next fixing the rest of states?
Definitely SGTM, thanks.
next prev parent reply other threads:[~2023-04-06 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:25 [PATCH net 0/2][pull request] iavf: fix racing in VLANs Tony Nguyen
2023-04-04 17:25 ` [PATCH net 1/2] iavf: refactor VLAN filter states Tony Nguyen
2023-04-06 0:15 ` Jakub Kicinski
2023-04-06 0:50 ` Ahmed Zaki
2023-04-06 0:59 ` Jakub Kicinski
2023-04-06 18:55 ` Ahmed Zaki
2023-04-06 20:04 ` Jakub Kicinski [this message]
2023-04-04 17:25 ` [PATCH net 2/2] iavf: remove active_cvlans and active_svlans bitmaps Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406130415.1aa1d1cd@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).