From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3C3C761A6 for ; Fri, 7 Apr 2023 00:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237421AbjDGAS2 (ORCPT ); Thu, 6 Apr 2023 20:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbjDGAS1 (ORCPT ); Thu, 6 Apr 2023 20:18:27 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A64524C3F for ; Thu, 6 Apr 2023 17:18:25 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-54bf8af4063so59313717b3.7 for ; Thu, 06 Apr 2023 17:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680826705; x=1683418705; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3z+/NV0dPqokddCY1NlsxXvpM1kRG3zeyORz1bdClYA=; b=Ie+PkEdZ8NlP4tCL2e6yryjW43O3XlBR/u9iiXFJbrMgcpOc3IYxzbK4XarLY/c800 EXG+bqUm99QO6vRxqGGm6L0NFj0Pw4CjBYbEzTau0rzhcOGvAgnM9Uo5IfqMZnQS7rm1 keHAfSFEnykWagzbkDK1KJhuzdPGEQbG36JE6SsUX1oZF2k7fIXPYJx1wg0LP2dYC+0n qNK1r8WguwjJ3Et1uGsyLEP3V6c6ipuIZlxizPlgqJIKZVmfhCH7l3Xg7bHM+ZptjsfE f+OGQyLSDyReUxbTJGma+JqRqXVN3DAhfOeHehKH+lrI1JZJ1gBCq6eHAK0XqL+3LQw1 yLrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680826705; x=1683418705; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3z+/NV0dPqokddCY1NlsxXvpM1kRG3zeyORz1bdClYA=; b=e98yi6ZZcGm26sU7RmMyJMFHYpKRaB63IuJVPjvtiaEWLBLSHHMvbW6muhH0q5mAaw QlUjIvKINPce/VKFIkMXmQHgsuO/BINX2JkMk5tQU/45wo2mrk0EZI7O5OGakLX4vGGn 6+VtAhyMAoqU+0sswizqfur6zvsBFLNLZuEBQlASNYC90nA235P/ab8esnwhN74K0r0e /XsrVCb1j3wUKjwETJc61+GoeBuVEWQm9GU1lAndQSfR1CE2o6x5q/WbTe1C78PDwCiW wJe8qOlI53FrO+ZgL/7+kaWddzkh65/KzOddnPYOcv1X1yU/LS3pnT+YwZWtcSSwsFpc I8eg== X-Gm-Message-State: AAQBX9fGmATbcR7N4j2iqHbujS64zm7au1+F2EuJaJqPnaWc4+lUIXQe ZDgPRLa2IhF/2d+fom4YvHFzN+hw X-Google-Smtp-Source: AKy350YirQjSwlcK32mrO8lnWvk2qTJsYhBwSukQ/GdXrsixXKlrQORwIQb2OB7EAa5VenlcolW2BFg+ X-Received: from gnomeregan.cam.corp.google.com ([2620:15c:93:4:5600:3a73:ddd5:3f6f]) (user=brho job=sendgmr) by 2002:a25:7716:0:b0:b6a:2590:6c63 with SMTP id s22-20020a257716000000b00b6a25906c63mr214401ybc.2.1680826704897; Thu, 06 Apr 2023 17:18:24 -0700 (PDT) Date: Thu, 6 Apr 2023 20:18:08 -0400 In-Reply-To: <20230405225246.1327344-1-brho@google.com> Mime-Version: 1.0 References: <20230405225246.1327344-1-brho@google.com> X-Mailer: git-send-email 2.40.0.577.gac1e443424-goog Message-ID: <20230407001808.1622968-1-brho@google.com> Subject: [PATCH bpf-next] bpf: ensure all memory is initialized in bpf_get_current_comm From: Barret Rhoden To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org BPF helpers that take an ARG_PTR_TO_UNINIT_MEM must ensure that all of the memory is set, including beyond the end of the string. Signed-off-by: Barret Rhoden --- kernel/bpf/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 6be16db9f188..b6a5cda5bb59 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -258,7 +258,7 @@ BPF_CALL_2(bpf_get_current_comm, char *, buf, u32, size) goto err_clear; /* Verifier guarantees that size > 0 */ - strscpy(buf, task->comm, size); + strscpy_pad(buf, task->comm, size); return 0; err_clear: memset(buf, 0, size); -- 2.40.0.577.gac1e443424-goog