From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
herbert@gondor.apana.org.au, alexander.duyck@gmail.com,
hkallweit1@gmail.com, andrew@lunn.ch, willemb@google.com,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH net-next v4 6/7] bnxt: use new queue try_stop/try_wake macros
Date: Fri, 7 Apr 2023 07:36:01 -0700 [thread overview]
Message-ID: <20230407073601.36374c99@kernel.org> (raw)
In-Reply-To: <CANn89iJrBGSybMX1FqrhCEMWT3Nnz2=2+aStsbbwpWzKHjk51g@mail.gmail.com>
On Fri, 7 Apr 2023 11:25:23 +0200 Eric Dumazet wrote:
> BTW, we should make sure the @desc argument of netif_txq_try_stop() is
> correctly implemented.
> I often see drivers with either buggy or not efficient implementation.
What do you have in mind?
Should we update the sample code in driver.rst further?
There is outdated sample code there:
https://www.kernel.org/doc/html/next/networking/driver.html
but IDK if people read the documentation :(
next prev parent reply other threads:[~2023-04-07 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 1:25 [PATCH net-next v4 0/7] net: lockless stop/wake combo macros Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 1/7] docs: net: reformat driver.rst from a list to sections Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 2/7] docs: net: move the probe and open/close sections of driver.rst up Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 3/7] docs: net: use C syntax highlight in driver.rst Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 4/7] net: provide macros for commonly copied lockless queue stop/wake code Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 5/7] ixgbe: use new queue try_stop/try_wake macros Jakub Kicinski
2023-04-07 1:25 ` [PATCH net-next v4 6/7] bnxt: " Jakub Kicinski
2023-04-07 9:25 ` Eric Dumazet
2023-04-07 14:36 ` Jakub Kicinski [this message]
2023-04-07 1:25 ` [PATCH net-next v4 7/7] net: piggy back on the memory barrier in bql when waking queues Jakub Kicinski
2023-04-11 1:30 ` [PATCH net-next v4 0/7] net: lockless stop/wake combo macros patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407073601.36374c99@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).