* Re: [PATCH] net: stmmac: fix system hang when setting up standalone tag_8021q VLAN for DSA ports [not found] <20230406100437.5402-1-rocklouts@sina.com> @ 2023-04-08 2:57 ` Jakub Kicinski [not found] ` <20230408155823.12834-1-rocklouts@sina.com> 0 siblings, 1 reply; 2+ messages in thread From: Jakub Kicinski @ 2023-04-08 2:57 UTC (permalink / raw) To: louts Cc: davem, alexandre.torgue, peppe.cavallaro, joabreu, edumazet, pabeni, mcoquelin.stm32, netdev, linux-stm32, linux-arm-kernel On Thu, 6 Apr 2023 18:04:37 +0800 louts wrote: > The system hang because of dsa_tag_8021q_port_setup() callbcak > stmmac_vlan_rx_add_vid().I found in stmmac_drv_probe() that > cailing pm_runtime_put() disabled the clock when check the stmmac > dirver. > > First, when the kernel is compiled with CONFIG_PM=y,The stmmac's > resume/suspend is active. > > Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function > will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, > The system is hanged for the stmmac_vlan_rx_add_vid() accesses its > registers after stmmac's clock is closed. > > I would suggest adding the pm_runtime_resume_and_get() to the > stmmac_vlan_rx_add_vid().This guarantees that resuming clock output > while in use. > > Signed-off-by: louts <rocklouts@sina.com> Is that your full name? If your name is not in the Latin alphabet feel free to put it in brackets after the Latin version, e.g.: Signed-off-by: John (якесь ім'я) <john@bla.abc> > @@ -6198,16 +6202,19 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid > ret = stmmac_vlan_update(priv, is_double); > if (ret) { > clear_bit(vid, priv->active_vlans); > - return ret; > + goto update_vlan_error; > } > > if (priv->hw->num_vlan) { > ret = stmmac_add_hw_vlan_rx_fltr(priv, ndev, priv->hw, proto, vid); > if (ret) > - return ret; > + goto add_vlan_error; > } > +update_vlan_error: > +add_vlan_error: Name the labels after the target please. err_pm_put: > + pm_runtime_put(priv->device); > > - return 0; > + return ret; ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20230408155823.12834-1-rocklouts@sina.com>]
* Re: [PATCH] net: stmmac:fix system hang when setting up standalone tag_8021q VLAN for DSA ports [not found] ` <20230408155823.12834-1-rocklouts@sina.com> @ 2023-04-11 0:32 ` Jakub Kicinski 0 siblings, 0 replies; 2+ messages in thread From: Jakub Kicinski @ 2023-04-11 0:32 UTC (permalink / raw) To: Yan Wang Cc: davem, alexandre.torgue, peppe.cavallaro, joabreu, edumazet, pabeni, mcoquelin.stm32, netdev, linux-stm32, linux-arm-kernel, linux-kernel, John 'Warthog9' Hawley On Sat, 8 Apr 2023 23:58:23 +0800 Yan Wang wrote: > The system hang because of dsa_tag_8021q_port_setup() callbcak > stmmac_vlan_rx_add_vid().I found in stmmac_drv_probe() that > cailing pm_runtime_put() disabled the clock when check the stmmac > dirver. > > First, when the kernel is compiled with CONFIG_PM=y,The stmmac's > resume/suspend is active. > > Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function > will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, > The system is hanged for the stmmac_vlan_rx_add_vid() accesses its > registers after stmmac's clock is closed. > > I would suggest adding the pm_runtime_resume_and_get() to the > stmmac_vlan_rx_add_vid().This guarantees that resuming clock output > while in use. Hm, the patch is not making it to the @vger list, even tho it did make it to lore.kernel.org, it seems. I couldn't spot anything wrong with it. Could you try sending it to testing@vger.kernel.org and contacting John (added to CC) who administers vger.kernel.org, to figure out what's wrong? Based on this conversation: https://lore.kernel.org/all/9539b880-642d-9ac5-ccfa-2b237548f4fc@kernel.org/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-11 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230406100437.5402-1-rocklouts@sina.com>
2023-04-08 2:57 ` [PATCH] net: stmmac: fix system hang when setting up standalone tag_8021q VLAN for DSA ports Jakub Kicinski
[not found] ` <20230408155823.12834-1-rocklouts@sina.com>
2023-04-11 0:32 ` [PATCH] net: stmmac:fix " Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).