* [PATCH net-next] net/mlx5: Include proper PCI headers file to fix compilation error
@ 2023-04-09 7:48 Leon Romanovsky
2023-04-09 10:10 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2023-04-09 7:48 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Leon Romanovsky, Eli Cohen, Eric Dumazet, Jacob Keller, netdev,
Paolo Abeni, Saeed Mahameed, Shay Drory
From: Leon Romanovsky <leonro@nvidia.com>
Fix the following compilation error, which happens due to missing pci.h
include.
drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:148:31: error: implicit declaration of function
'pci_msix_can_alloc_dyn' [-Werror=implicit-function-declaration]
Fixes: 3354822cde5a ("net/mlx5: Use dynamic msix vectors allocation")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
index e12e528c09f5..bb97d6ff8135 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
@@ -5,6 +5,7 @@
#include <linux/notifier.h>
#include <linux/mlx5/driver.h>
#include <linux/mlx5/vport.h>
+#include <linux/pci.h>
#include "mlx5_core.h"
#include "mlx5_irq.h"
#include "pci_irq.h"
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net/mlx5: Include proper PCI headers file to fix compilation error
2023-04-09 7:48 [PATCH net-next] net/mlx5: Include proper PCI headers file to fix compilation error Leon Romanovsky
@ 2023-04-09 10:10 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2023-04-09 10:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Eli Cohen, Eric Dumazet, Jacob Keller, netdev, Paolo Abeni,
Saeed Mahameed, Shay Drory
On Sun, Apr 09, 2023 at 10:48:43AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fix the following compilation error, which happens due to missing pci.h
> include.
>
> drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:148:31: error: implicit declaration of function
> 'pci_msix_can_alloc_dyn' [-Werror=implicit-function-declaration]
>
> Fixes: 3354822cde5a ("net/mlx5: Use dynamic msix vectors allocation")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 1 +
> 1 file changed, 1 insertion(+)
Actually, this patch is not needed.
The fix is in PCI tree.
https://lore.kernel.org/all/310ecc4815dae4174031062f525245f0755c70e2.1680119924.git.reinette.chatre@intel.com/
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-09 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-09 7:48 [PATCH net-next] net/mlx5: Include proper PCI headers file to fix compilation error Leon Romanovsky
2023-04-09 10:10 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).