From: Leon Romanovsky <leon@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
wojciech.drewek@intel.com, piotr.raczynski@intel.com,
pmenzel@molgen.mpg.de, aleksander.lobakin@intel.com,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v4 1/5] ice: define meta data to match in switch
Date: Sun, 9 Apr 2023 13:33:40 +0300 [thread overview]
Message-ID: <20230409103340.GJ14869@unreal> (raw)
In-Reply-To: <20230407165219.2737504-2-michal.swiatkowski@linux.intel.com>
On Fri, Apr 07, 2023 at 06:52:15PM +0200, Michal Swiatkowski wrote:
> Add description for each meta data. Redefine tunnel mask to match only
> tunneled MAC and tunneled VLAN. It shouldn't try to match other flags
> (previously it was 0xff, it is redundant).
>
> VLAN mask was 0xd000, change it to 0xf000. 4 last bits are flags
> depending on the same field in packets (VLAN tag). Because of that,
> It isn't harmful to match also on ITAG.
>
> Group all MDID and MDID offsets into enums to keep things organized.
>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> .../ethernet/intel/ice/ice_protocol_type.h | 186 +++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_switch.c | 11 +-
> .../net/ethernet/intel/ice/ice_vlan_mode.c | 2 +-
> 3 files changed, 183 insertions(+), 16 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-04-09 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 16:52 [PATCH net-next v4 0/5] ice: allow matching on meta data Michal Swiatkowski
2023-04-07 16:52 ` [PATCH net-next v4 1/5] ice: define meta data to match in switch Michal Swiatkowski
2023-04-09 10:33 ` Leon Romanovsky [this message]
2023-04-24 6:43 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-04-07 16:52 ` [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule info Michal Swiatkowski
2023-04-09 10:33 ` Leon Romanovsky
2023-04-24 6:40 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-04-07 16:52 ` [PATCH net-next v4 3/5] ice: specify field names in ice_prot_ext init Michal Swiatkowski
2023-04-07 19:25 ` Simon Horman
2023-04-09 10:34 ` Leon Romanovsky
2023-04-24 6:39 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-04-07 16:52 ` [PATCH net-next v4 4/5] ice: allow matching on meta data Michal Swiatkowski
2023-04-09 10:33 ` Leon Romanovsky
2023-04-24 6:37 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-04-07 16:52 ` [PATCH net-next v4 5/5] ice: use src VSI instead of src MAC in slow-path Michal Swiatkowski
2023-04-09 10:34 ` Leon Romanovsky
2023-04-24 6:35 ` [Intel-wired-lan] " Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230409103340.GJ14869@unreal \
--to=leon@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.raczynski@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=simon.horman@corigine.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).