From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C489C77B71 for ; Sun, 9 Apr 2023 10:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbjDIKk5 (ORCPT ); Sun, 9 Apr 2023 06:40:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjDIKk4 (ORCPT ); Sun, 9 Apr 2023 06:40:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC68C3594 for ; Sun, 9 Apr 2023 03:40:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 53D1B60B24 for ; Sun, 9 Apr 2023 10:40:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D17C433D2; Sun, 9 Apr 2023 10:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681036850; bh=i+CfACV444wnveH+XkdNRMwBK4Yqr89KjI7V+Qz+elY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sCo0UQ/DsgzFZRO8IzteHIMcExFrECh/AMRpLazTemoLCwepwzmOf291BE64sLJZH 125RCaufld05B/N4UYxgbdy/P5Ue7ucGPo8TxRZIG7CQ8P9+OqdJrJqRDeKQWX98zE D47rvkoIlCzOwJotopR0O1kiWV2IareOE7AjqSTJtmsnv6ANwviMxHELHb6Xwj56TO PUd9mlhSykeAj5rgSUB6vB6stD2Rllr+WtafImP6t4nbH91Jwm90zqS6/EJhpgxoOF 15V+/yVi+dRZbbr7go09OdGXqy8BowtptWsuSxNnbdbKHiBCAzpMrTNO8JskQW2u9W 2jZ4JABab6OHw== Date: Sun, 9 Apr 2023 13:40:46 +0300 From: Leon Romanovsky To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Ahmed Zaki , Rafal Romanowski Subject: Re: [PATCH net v2 1/2] iavf: refactor VLAN filter states Message-ID: <20230409104046.GO14869@unreal> References: <20230407210730.3046149-1-anthony.l.nguyen@intel.com> <20230407210730.3046149-2-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230407210730.3046149-2-anthony.l.nguyen@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 07, 2023 at 02:07:29PM -0700, Tony Nguyen wrote: > From: Ahmed Zaki > > The VLAN filter states are currently being saved as individual bits. > This is error prone as multiple bits might be mistakenly set. > > Fix by replacing the bits with a single state enum. Also, add an > "ACTIVE" state for filters that are accepted by the PF. > > Signed-off-by: Ahmed Zaki > Tested-by: Rafal Romanowski > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/iavf/iavf.h | 15 +++++---- > drivers/net/ethernet/intel/iavf/iavf_main.c | 8 ++--- > .../net/ethernet/intel/iavf/iavf_virtchnl.c | 31 +++++++++---------- > 3 files changed, 28 insertions(+), 26 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky