From: Chris Leech <cleech@redhat.com>
To: linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
Hannes Reinecke <hare@suse.de>,
Lee Duncan <leeman.duncan@gmail.com>,
netdev@vger.kernel.org
Cc: Chris Leech <cleech@redhat.com>
Subject: [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits
Date: Mon, 10 Apr 2023 12:10:33 -0700 [thread overview]
Message-ID: <20230410191033.1069293-3-cleech@redhat.com> (raw)
In-Reply-To: <83de4002-6846-2f90-7848-ef477f0b0fe5@suse.de>
The namespace is gone, so there is no userspace to clean up.
Force close all the sessions.
This should be enough for software transports, there's no implementation
of migrating physical iSCSI hosts between network namespaces currently.
Signed-off-by: Chris Leech <cleech@redhat.com>
---
drivers/scsi/scsi_transport_iscsi.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 3a068d8eca2d..8fafa8f0e0df 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -5200,9 +5200,27 @@ static int __net_init iscsi_net_init(struct net *net)
static void __net_exit iscsi_net_exit(struct net *net)
{
+ struct iscsi_cls_session *session, *tmp;
+ struct iscsi_transport *transport;
struct iscsi_net *isn;
+ unsigned long flags;
+ LIST_HEAD(sessions);
isn = net_generic(net, iscsi_net_id);
+
+ /* force session destruction, there is no userspace anymore */
+ spin_lock_irqsave(&isn->sesslock, flags);
+ list_for_each_entry_safe(session, tmp, &isn->sesslist, sess_list) {
+ list_move_tail(&session->sess_list, &sessions);
+ }
+ spin_unlock_irqrestore(&isn->sesslock, flags);
+ list_for_each_entry_safe(session, tmp, &sessions, sess_list) {
+ device_for_each_child(&session->dev, NULL,
+ iscsi_iter_force_destroy_conn_fn);
+ transport = session->transport;
+ transport->destroy_session(session);
+ }
+
netlink_kernel_release(isn->nls);
isn->nls = NULL;
}
--
2.39.2
next prev parent reply other threads:[~2023-04-10 19:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:40 [RFC 0/9] Make iscsid-kernel communications namespace-aware Lee Duncan
2023-02-08 17:40 ` [RFC PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets Lee Duncan
2023-03-14 16:21 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 2/9] iscsi: associate endpoints with a host Lee Duncan
2023-03-14 16:23 ` Hannes Reinecke
2023-03-17 21:42 ` Lee Duncan
2023-04-12 2:31 ` Chris Leech
2023-04-20 16:42 ` Chris Leech
2023-02-08 17:40 ` [RFC PATCH 3/9] iscsi: sysfs filtering by network namespace Lee Duncan
2023-03-14 16:24 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware Lee Duncan
2023-03-14 16:27 ` Hannes Reinecke
2023-04-10 19:10 ` Chris Leech
2023-04-11 6:22 ` Hannes Reinecke
2023-04-10 19:10 ` [PATCH 10/11] iscsi: make session and connection lists per-net Chris Leech
2023-04-11 6:17 ` Hannes Reinecke
2023-04-10 19:10 ` Chris Leech [this message]
2023-04-11 6:21 ` [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits Hannes Reinecke
2023-04-11 18:19 ` Chris Leech
2023-04-12 6:02 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 5/9] iscsi: set netns for iscsi_tcp hosts Lee Duncan
2023-03-14 16:29 ` Hannes Reinecke
2023-04-11 0:21 ` Chris Leech
2023-04-11 6:58 ` Hannes Reinecke
2023-04-11 18:03 ` Chris Leech
2023-02-08 17:40 ` [RFC PATCH 6/9] iscsi: check net namespace for all iscsi lookup Lee Duncan
2023-03-14 17:44 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 7/9] iscsi: convert flashnode devices from bus to class Lee Duncan
2023-03-14 17:45 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_* Lee Duncan
2023-03-14 17:46 ` Hannes Reinecke
2023-02-08 17:40 ` [RFC PATCH 9/9] iscsi: filter flashnode sysfs by net namespace Lee Duncan
2023-03-14 17:47 ` Hannes Reinecke
2023-02-08 19:23 ` [RFC 0/9] Make iscsid-kernel communications namespace-aware (resent) Lee Duncan
2023-03-14 16:20 ` [RFC 0/9] Make iscsid-kernel communications namespace-aware Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2023-05-06 23:29 [PATCH v2 00/11] " Chris Leech
2023-05-06 23:29 ` [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits Chris Leech
2023-05-10 20:09 ` michael.christie
2023-05-10 20:14 ` michael.christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410191033.1069293-3-cleech@redhat.com \
--to=cleech@redhat.com \
--cc=hare@suse.de \
--cc=leeman.duncan@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).