From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372CDC76196 for ; Tue, 11 Apr 2023 04:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbjDKE7h (ORCPT ); Tue, 11 Apr 2023 00:59:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbjDKE7g (ORCPT ); Tue, 11 Apr 2023 00:59:36 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA6CEE6F for ; Mon, 10 Apr 2023 21:59:34 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm66N-0001qd-8r; Tue, 11 Apr 2023 06:59:31 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pm66K-00055m-CO; Tue, 11 Apr 2023 06:59:28 +0200 Date: Tue, 11 Apr 2023 06:59:28 +0200 From: Oleksij Rempel To: Jakub Kicinski Cc: netdev@vger.kernel.org, Woojung Huh , Andrew Lunn , Arun Ramadoss , Florian Fainelli , UNGLinuxDriver@microchip.com, Eric Dumazet , Vladimir Oltean , kernel@pengutronix.de, Paolo Abeni , "David S. Miller" Subject: Re: [PATCH net-next v1 1/1] net: dsa: microchip: ksz8: Make flow control, speed, and duplex on CPU port configurable Message-ID: <20230411045928.GA13401@pengutronix.de> References: <20230404101225.1382059-1-o.rempel@pengutronix.de> <20230406190404.14e38e67@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230406190404.14e38e67@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 06, 2023 at 07:04:04PM -0700, Jakub Kicinski wrote: > On Tue, 4 Apr 2023 12:12:25 +0200 Oleksij Rempel wrote: > > Allow flow control, speed, and duplex settings on the CPU port to be > > configurable. Previously, the speed and duplex relied on default switch > > values, which limited flexibility. Additionally, flow control was > > hardcoded and only functional in duplex mode. This update enhances the > > configurability of these parameters. > > Anyone who knows DSA/phylink willing to venture a review tag? :) For the archive, review is started here: https://lore.kernel.org/all/ZDBWdFGN7zmF2A3N@shell.armlinux.org.uk/ -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |