From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898B2C77B6F for ; Tue, 11 Apr 2023 12:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjDKMrj (ORCPT ); Tue, 11 Apr 2023 08:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjDKMrh (ORCPT ); Tue, 11 Apr 2023 08:47:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C046F2D63 for ; Tue, 11 Apr 2023 05:47:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A42761CEA for ; Tue, 11 Apr 2023 12:47:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40391C433EF; Tue, 11 Apr 2023 12:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681217255; bh=DxcezAwFe3nKSveHy+rOWYFpKqezwqAU05kit3IxdFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N/XTf+v0Ej2zfTskH6kLXpSV+i3GX9JftEAegTayTBVPXfjtZuFuEWrcFiUDZXQ+p HnCBOoffZB2mtF/Y6QdmqkW3xjbgAC7SzMJMMA0V/N5JpArDUt6JrchnI8bV5qDRTH x+Ac4PVGbIqsLq0jtsvl/hMUFSWIdhOunmS2frnLFoLMZmQ5HoNowqxuXxbX2+X3jK 6jhOkxV7+9pl+HSiYJHza9MMbUSp3KVR1YPGCpRuF3+3Bn6+pNujW39ZtkIRAINuME 0se2LJFYzwMZst18/Oa1dc9LOqu9yn5KH/G43Kx53Q7HfNgp9laJFEYNvQyssTN7MI WUPel38p2FMhg== Date: Tue, 11 Apr 2023 15:47:31 +0300 From: Leon Romanovsky To: Simon Horman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , netdev@vger.kernel.org, Saeed Mahameed , Raed Salem , Emeel Hakim Subject: Re: [PATCH net-next 09/10] net/mlx5e: Create IPsec table with tunnel support only when encap is disabled Message-ID: <20230411124731.GY182481@unreal> References: <20230410164920.GU182481@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 10, 2023 at 08:10:14PM +0200, Simon Horman wrote: > On Mon, Apr 10, 2023 at 07:49:20PM +0300, Leon Romanovsky wrote: > > On Mon, Apr 10, 2023 at 04:29:09PM +0200, Simon Horman wrote: > > > On Mon, Apr 10, 2023 at 09:19:11AM +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > > > > > Current hardware doesn't support double encapsulation which is > > > > happening when IPsec packet offload tunnel mode is configured > > > > together with eswitch encap option. > > > > > > > > Any user attempt to add new SA/policy after he/she sets encap mode, will > > > > generate the following FW syndrome: > > > > > > > > mlx5_core 0000:08:00.0: mlx5_cmd_out_err:803:(pid 1904): CREATE_FLOW_TABLE(0x930) op_mod(0x0) failed, > > > > status bad parameter(0x3), syndrome (0xa43321), err(-22) > > > > > > > > Make sure that we block encap changes before creating flow steering tables. > > > > This is applicable only for packet offload in tunnel mode, while packet > > > > offload in transport mode and crypto offload, don't have such limitation > > > > as they don't perform encapsulation. > > > > > > > > Reviewed-by: Raed Salem > > > > Signed-off-by: Leon Romanovsky > > > > > > Hi Raed and Leon, > > > > > > some minor feedback from me below. > > > > > > > --- > > > > .../mellanox/mlx5/core/en_accel/ipsec.c | 7 ++++ > > > > .../mellanox/mlx5/core/en_accel/ipsec.h | 1 + > > > > .../mellanox/mlx5/core/en_accel/ipsec_fs.c | 33 +++++++++++++++++-- > > > > 3 files changed, 38 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > > > index b64281fd4142..e95004ac7a20 100644 > > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > > > @@ -668,6 +668,13 @@ static int mlx5e_xfrm_add_state(struct xfrm_state *x, > > > > if (err) > > > > goto err_hw_ctx; > > > > > > > > + if (x->props.mode == XFRM_MODE_TUNNEL && > > > > + x->xso.type == XFRM_DEV_OFFLOAD_PACKET && > > > > + !mlx5e_ipsec_fs_tunnel_enabled(sa_entry)) { > > > > + NL_SET_ERR_MSG_MOD(extack, "Packet offload tunnel mode is disabled due to encap settings"); > > > > + goto err_add_rule; > > > > > > The err_add_rule will return err. > > > But err is zero here. > > > Perhaps it should be set to an negative error code? > > > > Thanks, I overlooked it. > > > > > > > > Flagged by Smatch as: > > > > > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c:753 mlx5e_xfrm_free_state() error: we previously assumed 'sa_entry->work' could be null (see line 744) > > > > I don't get such warnings from my CI, will try to understand why. > > > > What are the command line arguments you use to run smatch? > > Hi Leon, > > I run Smatch like this: > > .../smatch/smatch_scripts/kchecker \ > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.o > > > What is the version of smatch? > > I see this with Smatch 1.73. > > > In writing this email, I noticed that Smatch seems to flag > a problem in net-next. Which seems to be a valid concern. > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c:753 mlx5e_xfrm_free_state() error: we previously assumed 'sa_entry->work' could be null (see line 744) Thanks, I'll take a look when will return to the office.