From: Jakub Kicinski <kuba@kernel.org>
To: <edward.cree@amd.com>
Cc: <linux-net-drivers@amd.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
Edward Cree <ecree.xilinx@gmail.com>, <netdev@vger.kernel.org>,
<habetsm.xilinx@gmail.com>, <sudheer.mogilappagari@intel.com>
Subject: Re: [RFC PATCH v2 net-next 2/7] net: ethtool: attach an IDR of custom RSS contexts to a netdevice
Date: Wed, 12 Apr 2023 18:39:22 -0700 [thread overview]
Message-ID: <20230412183922.530b471c@kernel.org> (raw)
In-Reply-To: <16030cc69a6726cda461290a3d6bed9c48db7562.1681236653.git.ecree.xilinx@gmail.com>
On Tue, 11 Apr 2023 19:26:10 +0100 edward.cree@amd.com wrote:
> +static void netdev_rss_contexts_free(struct net_device *dev)
> +{
> + struct ethtool_rxfh_context *ctx;
> + u32 context;
> +
> + if (!dev->ethtool_ops->set_rxfh_context)
> + return;
> + idr_for_each_entry(&dev->ethtool->rss_ctx, ctx, context) {
> + u32 *indir = ethtool_rxfh_context_indir(ctx);
> + u8 *key = ethtool_rxfh_context_key(ctx);
> +
> + idr_remove(&dev->ethtool->rss_ctx, context);
> + dev->ethtool_ops->set_rxfh_context(dev, indir, key, ctx->hfunc,
> + &context, true);
> + kfree(ctx);
> + }
> +}
nit: maybe move the ethtool related code out to a new
net/ethtool/netdev.c ? We can probably put forward declarations
in net/core/dev.h or a new header among sources?
next prev parent reply other threads:[~2023-04-13 1:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 18:26 [RFC PATCH v2 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2023-04-11 18:26 ` [RFC PATCH v2 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2023-04-11 20:37 ` Andrew Lunn
2023-04-13 1:36 ` Jakub Kicinski
2023-04-11 18:26 ` [RFC PATCH v2 net-next 2/7] net: ethtool: attach an IDR of custom RSS contexts to a netdevice edward.cree
2023-04-11 20:36 ` Andrew Lunn
2023-04-12 15:52 ` Edward Cree
2023-04-13 1:39 ` Jakub Kicinski [this message]
2023-04-11 18:26 ` [RFC PATCH v2 net-next 3/7] net: ethtool: record custom RSS contexts in the IDR edward.cree
2023-04-13 1:49 ` Jakub Kicinski
2023-06-09 20:01 ` Edward Cree
2023-04-11 18:26 ` [RFC PATCH v2 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2023-04-13 1:53 ` Jakub Kicinski
2023-04-11 18:26 ` [RFC PATCH v2 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2023-04-11 18:26 ` [RFC PATCH v2 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-04-11 20:40 ` Andrew Lunn
2023-04-12 16:16 ` Edward Cree
2023-04-12 17:15 ` Andrew Lunn
2023-04-12 17:42 ` Edward Cree
2023-04-13 2:06 ` Jakub Kicinski
2023-04-13 21:52 ` Edward Cree
2023-04-13 21:58 ` Andrew Lunn
2023-04-14 20:20 ` Edward Cree
2023-04-11 18:26 ` [RFC PATCH v2 net-next 7/7] sfc: use new rxfh_context API edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412183922.530b471c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).