From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, richardcochran@gmail.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [RFC PATCH v1] ice: add CGU info to devlink info callback
Date: Wed, 12 Apr 2023 20:35:00 -0700 [thread overview]
Message-ID: <20230412203500.36fb7c36@kernel.org> (raw)
In-Reply-To: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com>
On Wed, 12 Apr 2023 15:38:11 +0200 Arkadiusz Kubalewski wrote:
> If Clock Generation Unit and dplls are present on NIC board user shall
> know its details.
> Provide the devlink info callback with a new:
> - fixed type object `cgu.id` - hardware variant of onboard CGU
> - running type object `fw.cgu` - CGU firmware version
> - running type object `fw.cgu.build` - CGU configuration build version
>
> These information shall be known for debugging purposes.
>
> Test (on NIC board with CGU)
> $ devlink dev info <bus_name>/<dev_name> | grep cgu
> cgu.id 8032
> fw.cgu 6021
> fw.cgu.build 0x1030001
>
> Test (on NIC board without CGU)
> $ devlink dev info <bus_name>/<dev_name> | grep cgu -c
> 0
>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Is it flashed together with the rest of the FW components of the NIC?
Or the update method is different?
next prev parent reply other threads:[~2023-04-13 3:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 13:38 [RFC PATCH v1] ice: add CGU info to devlink info callback Arkadiusz Kubalewski
2023-04-13 3:35 ` Jakub Kicinski [this message]
2023-04-13 13:43 ` Kubalewski, Arkadiusz
2023-04-13 15:04 ` Jakub Kicinski
2023-04-14 10:04 ` Kubalewski, Arkadiusz
2023-04-14 14:46 ` Jakub Kicinski
2023-04-13 13:17 ` Leon Romanovsky
2023-04-13 14:04 ` Kubalewski, Arkadiusz
2023-04-13 17:17 ` Leon Romanovsky
2023-04-14 10:06 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412203500.36fb7c36@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).