From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8AEC77B6E
	for <netdev@archiver.kernel.org>; Thu, 13 Apr 2023 16:03:50 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229578AbjDMQDt (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 13 Apr 2023 12:03:49 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44424 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229481AbjDMQDs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 13 Apr 2023 12:03:48 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5686B4EF2
        for <netdev@vger.kernel.org>; Thu, 13 Apr 2023 09:03:47 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id E2FFB6227F
        for <netdev@vger.kernel.org>; Thu, 13 Apr 2023 16:03:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA76EC433D2;
        Thu, 13 Apr 2023 16:03:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1681401826;
        bh=Rc5ZK0hEjJCUPLbarklfttD8GZ7zgofLPT8Ny5BT6ac=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=FDEagfpji6+VQ7vc82LIuUWvzZ3mHINa2z7GCkahDSUnFzV1BxkQlMxxwUQdB7UVH
         kCVWlOTqGx0ZQTBuKuRy0Z6C6gqBL+jFf41fQ3mg6XDYa2EfYdPMw3+p8jTFEgOGvH
         j8d5J3ufTegt+/5v2miE03fQ323wwQJCW4Y1snt23mefUV/QK7ImUL1pSac5U7Dt8O
         lRbHsyp0mN5NWAGASCFxT8ZQEeNUX0CIjdxDF1P/biOyfFEREzexdeYi3wgfbrkMnT
         KpGl+7aNj4rv463i1A5a8xNyD4LX+XyTCe1A8sbJhW6zhkrAhl44ksQiNRvQCvNoJW
         cON6yvABNcAUA==
Date:   Thu, 13 Apr 2023 09:03:44 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     Kurt Kanzenbach <kurt@linutronix.de>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        "Ong Boon Leong" <boon.leong.ong@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] igc: Avoid transmit queue timeout for XDP
Message-ID: <20230413090344.20796001@kernel.org>
In-Reply-To: <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com>
References: <20230412073611.62942-1-kurt@linutronix.de>
        <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, 12 Apr 2023 15:30:38 -0700 Jacob Keller wrote:
> Is most driver's XDP implementation broken? There's also
> netif_trans_update but this is called out as a legacy only function. Far
> more drivers call this but I don't see either call or a direct update to
> trans_start in many XDP implementations...
> 
> Am I missing something or are a bunch of other XDP implementations also
> wrong?

Only drivers which use the same Tx queues for the stack and XDP need
this.